Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
115 stars 57 forks source link

Spawner is not pushed into spawner minecart #837

Open suppergerrie2 opened 1 year ago

suppergerrie2 commented 1 year ago

Describe the bug Spawner minecarts cannot be created with orbis spawners

To Reproduce Steps to reproduce the behavior:

  1. Find an orbis spawner
  2. Place a rail under the orbis spawner, a piston pushing down on top of the spawner, a redstone block on top of the piston, and a minecart on the rail.
  3. Look at nothing happening

Expected behavior The spawner should be pushed into the minecart

Screenshots image

Environment

Additional context This bug was found on the gamemode 4 server,

728, 76, -423 has the following block data: {SpawnData: {entity: {id: "minecraft:skeleton", HandItems: [{id: "minecraft:bow", Count: 1b}, {}], DeathLootTable: "gm4_orbis:entities/skeleton"}, custom_spawn_rules: {block_light_limit: [0, 7], sky_light_limit: [8, 14]}}, MaxNearbyEntities: 6s, MinSpawnDelay: 200s, y: 76, id: "minecraft:mob_spawner", SpawnPotentials: [{weight: 1, data: {entity: {id: "minecraft:skeleton", HandItems: [{id: "minecraft:bow", Count: 1b}, {}], DeathLootTable: "gm4_orbis:entities/skeleton"}, custom_spawn_rules: {block_light_limit: [0, 7], sky_light_limit: [8, 14]}}}], x: 728, SpawnRange: 4s, MaxSpawnDelay: 800s, RequiredPlayerRange: 16s, SpawnCount: 4s, z: -423, Delay: -1s}

"Orbis spawners have 2 tags in SpawnPotentials[0].data which breaks the spawner minecart check "~ Epyon

EpyonProjects commented 1 year ago

Spawner data pulled by me from the current Public Server

suppergerrie2 commented 1 year ago

It seems like the orbis overhaul dropped the spawner minecart integration tags and functions, adding those back would fix this.