search

Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
108 stars 56 forks source link

1.20.4 errors for data packs #936

Closed PaladinFallen closed 8 months ago

PaladinFallen commented 8 months ago

Describe the bug Errors for grass, now called short_grass missing following references

To Reproduce Steps to reproduce the behavior:

  1. Load datapacks
  2. Read log

Expected behavior ...no errors?

Fix rename grass to short_grass (unknown about the references)

Environment

Additional context 11:44:57] [Worker-Main-1/ERROR]: Couldn't load tag gm4:replaceable as it is missing following references: minecraft:grass (from file/gm4_end_fishing_1_20.zip), minecraft:grass (from file/gm4_enderman_support_class_1_20.zip), minecraft:grass (from file/gm4_ink_spitting_squid_1_20.zip), minecraft:grass (from file/gm4_lightning_in_a_bottle_1_20.zip), minecraft:grass (from file/gm4_shroomites_1_20.zip), minecraft:grass (from file/gm4_sunken_treasure_1_20.zip)

[11:44:57] [Worker-Main-1/ERROR]: Couldn't load tag gm4:no_collision as it is missing following references: minecraft:grass (from file/gm4_end_fishing_1_20.zip), minecraft:grass (from file/gm4_enderman_support_class_1_20.zip), minecraft:grass (from file/gm4_ink_spitting_squid_1_20.zip), minecraft:grass (from file/gm4_lightning_in_a_bottle_1_20.zip), minecraft:grass (from file/gm4_shroomites_1_20.zip), minecraft:grass (from file/gm4_sunken_treasure_1_20.zip)

[11:44:57] [Worker-Main-1/ERROR]: Couldn't load tag gm4:foliage as it is missing following references: minecraft:grass (from file/gm4_end_fishing_1_20.zip), minecraft:grass (from file/gm4_enderman_support_class_1_20.zip), minecraft:grass (from file/gm4_ink_spitting_squid_1_20.zip), minecraft:grass (from file/gm4_lightning_in_a_bottle_1_20.zip), minecraft:grass (from file/gm4_shroomites_1_20.zip), minecraft:grass (from file/gm4_sunken_treasure_1_20.zip)

[11:44:57] [Worker-Main-1/ERROR]: Couldn't load tag gm4_shroomites:shroom_replacable as it is missing following references: #gm4:foliage (from file/gm4_shroomites_1_20.zip)

[11:44:57] [Worker-Main-1/ERROR]: Couldn't load tag gm4_soul_glass:beacon_passable as it is missing following references: #gm4:no_collision (from file/gm4_soul_glass.zip)

[12:30:26] [ServerMain/WARN]: Not all defined tags for registry ResourceKey[minecraft:root / minecraft:block] are present in data pack: gm4:foliage, gm4:no_collision, gm4_shroomites:shroom_replacable

misode commented 8 months ago

This issue is caused by a bug in fabric, which does not support overlays in data pack. They have a fix in-progress: https://github.com/FabricMC/fabric/pull/3473

Update: unlikely to be the problem, since that fabric bug only affects data packs packaged as mods, which our data packs are not.

Bloo-dev commented 8 months ago

Thank you for creating a bug report. The issue misode linked is likely the culpret. I installed the following modules on a freshly created vanilla world to make sure there's nothing wrong with the data packs:

And I could not replicate the errors on log described in this issue on my vanilla instance.

PaladinFallen commented 8 months ago

funny thing, I haven't ran this yet on a client yet. this is all produced by the servers log. I've had to manually go in and change the grass to short_grass.. So this isn't closed, but whatever I'm manually fixing everything anywho.

Bloo-dev commented 8 months ago

funny thing, I haven't ran this yet on a client yet.

Can you elaborate? As pointed out above, this may be caused by the modded server you are running, hence it would not happen in a vanilla single player instance (as my tests showed).

misode commented 8 months ago

Looking at this again, I have managed to run fabric in 1.20.4 with our modules. The only current explanation I can give is that some our your data packs may have not been recently downloaded? @PaladinFallen Could you try re-downloading all our data packs, making sure none remain from 1.20.2 or earlier?

Bloo-dev commented 8 months ago

Closing this as we haven't heard back from you in a while. We'll have to assume you were using outdated modules as that is a common cause for the issue you have described.