Update to mecha 0.87.0 and pydantic v2

Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.

https://gm4.co

GNU General Public License v3.0

108 stars 56 forks source link

Update to mecha 0.87.0 and pydantic v2 #961

Closed misode closed 7 months ago

misode commented 7 months ago

Tested that the output matches exactly with the current release.
- The only changes were nbt files and a bugfix in upgrade_paths/run.json. It seems like it was adding the function entry twice before.
Updating to mecha 0.87.0 instead of 0.88.8 because the latter changed the effect amplifier range to 0-127.
There are some # type: ignore in prefabs.json because it did not detect that nbtlib comes with beet. There may be a cleaner solution.
player_heads.py required some changes. It seems like beet now needs the db key to be a File, so I just pass a TextFile with source_path set to the json file and content to the same unique string. I haven't tested that diagnostic messages still work.

EpyonProjects commented 7 months ago

Using this PR, I was able to build successfully with my files that previously had issues :+1:

misode commented 7 months ago

I don't see the supposed bugfix in upgrade paths other than the import migration, so I'm not sure whats up with that.

If you download a module like block compressors right now, you can see that the file data/gm4_upgrade_paths/tags/functions/run.json currently looks like this:

{
  "values": [
    "gm4_custom_crafters-3.1:upgrade_paths/run",
    "gm4_custom_crafters-3.1:upgrade_paths/run"
  ]
}

I'm assuming the JSON support for mecha fixed this, although it might still be useful to look into why this was happening in the first place.

SpecialBuilder32 commented 7 months ago

..wait what? Mecha's json processing isn't actually in the project yet (its an opt in plugin I use in #918), so mecha shouldn't be like removing duplicate entries or anything. I... don't know what could be causing this. I'll try to take a quick look to see if its a concern at all.