Gamepiaynmo / CustomModel

Customize your player model in Minecraft using JSON.
http://cpmmod.top/
33 stars 30 forks source link

some features (mainly focuses on particles) #17

Closed dragon-evol closed 4 years ago

dragon-evol commented 4 years ago

When I'm working on the particle system, it seems that "is_first_person" doesn't actually stop particles from rendering, which means that this "is_first_person" refers to the "bone" instead of the "camera", i.e. the bone is part of the third person model or first person model (kind of like "additional" two arms).

The situation is that I bound some particles to the hand of my character and put "!is_first_person" in the bone's visibility condition, but when I am in first person view, the particles show as if the third person model is merely "hidden" (they appear at the position of my "third person hands" and swings back and forth when I walk, and follows the facing of the "third person body").

So I added one more function which checks if the current entity is "the player" and "the client" is in first person view.

I know the "getMinecraft" shall only be performed on the client side, but through my tests it seems that those functions are only called at client side so it seems fine? But this part is still makes me concerned... Maybe some security check are needed to prevent that from accidentally breaking the server.


Also, I found that emissive bones wouldn't bring emissive particles, so I added a little brightness system to particles so that they shine properly and can be controlled.

However, for now, I can only make the brightness change linearly (setting the brightness of the start and the end).