Add support for GH and RB style MIDI-based starpower note phrase designations

[GoogleCodeExporter]

-Add function to read in manual starpower section markings from MIDI file
instead of automatic calculation
-Add user option to force automatic starpower phrase generation, or use the
MIDI starpower phrase if available.

Original issue reported on code.google.com by chris.paiano@gmail.com on 26 Oct 2008 at 5:19

[GoogleCodeExporter]

Issue 262 has been merged into this issue.

Original comment by chris.paiano@gmail.com on 15 Nov 2008 at 11:12

[GoogleCodeExporter]

Original comment by chris.paiano@gmail.com on 21 Nov 2008 at 4:26

• Added labels: Milestone-Release-3.035

[GoogleCodeExporter]

This is a required first step, these marked starpower phrases must be taken into
account in order for issue 102 to be possible and make sense.

Original comment by chris.paiano@gmail.com on 21 Nov 2008 at 4:27

[GoogleCodeExporter]

I need details please; from anyone who is familiar with these starpower marking 
notes
in the MIDI files.  That would probably be any of you who have taken other 
songs and
created a working console game disc for a GH or RB....

i.e. what specific note marks starpower?  Is it different between GH and RB?  
Is it
different between GH, GH2, and GH3?  Is there a starpower marking note for each
difficulty or just one for all?  etc.. any info will be helpful.

Original comment by chris.paiano@gmail.com on 21 Nov 2008 at 4:39

[GoogleCodeExporter]

In fact, while you're at it, please provide details on all the other non-fret 
notes
in GH and RB song MIDIs.  I can't tell what they're supposed to do, but there 
are
lots of long marking notes throughout, for example, RB - REM - Orange Crush.

Original comment by chris.paiano@gmail.com on 21 Nov 2008 at 4:44

[GoogleCodeExporter]

not sure if this will help or not but i found it with a bit of searching:
http://rockband.scorehero.com/forum/viewtopic.php?p=82949&sid=f80c43936a0ab9eca9
87a57752328cb1#82949

Original comment by Qst...@gmail.com on 21 Nov 2008 at 5:48

[GoogleCodeExporter]

also this
http://www.scorehero.com/forum/viewtopic.php?t=1179

Original comment by Qst...@gmail.com on 21 Nov 2008 at 5:49

[GoogleCodeExporter]

As posted here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=25040&p=311428#p311428

"
about star power/overdrive

in gh3 its located opening the midi on track G8 line 8 (G#8)

in rockband its located opening the midi on line G9 line 9 (G#9)

edit: in rockband the solo section is marked on the same place where gh3 have
starpower thats why opening a rockband song in feedback you will see on the solo
section a blue line on the left
"

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 1:14

[GoogleCodeExporter]

Looks to me from RB - Orange Crush's MIDI file that the solo section is marked 
on G8
not G#8.

G#9 looks like it could indeed be for overdrive sections; although there is a 
rather
short note in there.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 1:18

[GoogleCodeExporter]

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 6:33

• Changed state: Started

[GoogleCodeExporter]

I will be making notes relevant to the development of the starpower / overdrive
pathing code here now; basically distilling the above information into FoFiX 
game logic.

Checking if GH-style game songs have any MIDI notes on G#9:
GH1: No
GH2: No
GH3: No
GHA: No
GH80: No

Well then.  I will be scanning for the existence of any activity on instrument
tracks' G#9 note to determine if this is a GH or RB style MIDI structure.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 6:52

[GoogleCodeExporter]

Added logic to extract RB-style overdrive note markers and GH-style starpower 
note
markers, and store them as special notes in the existing game note track 
objects.
New log entries added.
Committed work so far as r415.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 8:25

[GoogleCodeExporter]

Adding new debug / log setting: "Log Marker Notes" (default off) - allows 
enabling /
disabling of the log entries made when starpower / overdrive / other special 
marker
notes are detected.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 8:29

[GoogleCodeExporter]

New log setting tested & committed in r416.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 8:35

[GoogleCodeExporter]

Incoming new game setting: "Starpower Mode" (default Auto MIDI)
"Off" - This setting completely disables starpower notes. 
"FoF" - This setting generates starpower note phrases the old-fashioned FoF way
"Auto MIDI" - This setting will use RB or GH-style starpower phrase markings in 
the
MIDI file, if present.  Otherwise, will fall back on the FoF-generated 
starpower phrases.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 8:40

[GoogleCodeExporter]

IT WORKS! 
So far, only RB-style overdrive marking tested, and so far, no fallback logic 
exists
to auto-create starpower paths if no MIDI markers are found.... but it works!

Try it out in r417.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 9:29

[GoogleCodeExporter]

Automatic starpower phrase generation fallback logic added, if no GH or RB-style
starpower phrase markers are found when analyzing the song.  

This issue should be completely implemented in r418.

Please let me know if it behaves incorrectly, or if I did an outstanding job in 
a
single evening's work :)

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 9:39

[GoogleCodeExporter]

OK - so it only works correctly for Expert difficulty right now.  Other 
difficulties
will have no starpower notes when Auto MIDI is used.... 

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 10:00

[GoogleCodeExporter]

Hmm... We can add the starpower manually in the MIDI file? I don't think this is
great, because a people might cheating put the starpower at each notes. Like 
some
custom GHIII song, each notes has starpower. The starpower start and end at 
each notes.

Original comment by acrox...@gmail.com on 22 Nov 2008 at 11:09

[GoogleCodeExporter]

Only works for RB overdrive? HMmm.... I'll test later when I got to my 
computer. :)

Original comment by acrox...@gmail.com on 22 Nov 2008 at 11:12

[GoogleCodeExporter]

I can confirm it works in RB expert. Other RB difficulties seem to have no OD 
notes
at all with this enabled. GH3 songs still have FoF style calculated starpower 
notes.
From what I've read, this is all just confirming what you already know.

Original comment by death.au on 22 Nov 2008 at 1:09

[GoogleCodeExporter]

GH starpower is detected fine; GH3 songs just are stripped all to hell (at 
least the
MIDIs we have for FoF) and may not have any starpower paths in them.

If someone modifies a MIDI with ridiculous amounts of starpower paths to cheat, 
that
MIDI will upload scores to a different "song" - it's hash result will be 
different
than the unmodified MIDI.  So, who cares?

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 4:31

[GoogleCodeExporter]

Confirmed; GH3 MIDIs are stripped of just about everything except their playable
notes.  I've always said GH3 MIDIs need to be re-ripped.... no section markers, 
no
extractable solo sections like GH1 and GH2, and now no starpower paths.  For 
shame. 
Someone wasn't thinking about future development.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 4:35

[GoogleCodeExporter]

Now works for all GUITAR difficulties; however, it appears that no other 
instruments
are being marked as of yet.  Test the latest out in r419.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 4:55

[GoogleCodeExporter]

Man i wish i knew how to rip midi's or i could re-rip them since i have GH3 for 
pc.

Original comment by worldr...@hotmail.com on 22 Nov 2008 at 4:57

[GoogleCodeExporter]

there are many tutorials on it, ill try and see if i can figure it out today.

Original comment by Qst...@gmail.com on 22 Nov 2008 at 5:03

[GoogleCodeExporter]

Or, someone with a lot of time and patience can go through and add G8 notes to 
guitar
and bass tracks to mark out some starpower; but that's kinda ridiculous :)

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 5:03

[GoogleCodeExporter]

found a new issue with this, im playing MCR-This is how i disapeared which is a 
GH
DLC song, and when i turn on star power i still see star notes while it is 
turned on

Original comment by Qst...@gmail.com on 22 Nov 2008 at 5:27

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

That's a setting "SP Refill" - you can disable it.

In other words, that has nothing to do with this issue.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 5:43

[GoogleCodeExporter]

oh ok didnt know that.

Original comment by Qst...@gmail.com on 22 Nov 2008 at 5:48

[GoogleCodeExporter]

I just added issue 299, since we can now easily distinguish between RB and GH 
type
MIDI files, for a better "SP Refill" option.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 5:57

[GoogleCodeExporter]

sweet, yea cause i have never actually played rockband so i assumed something 
was wrong.

Original comment by Qst...@gmail.com on 22 Nov 2008 at 5:59

[GoogleCodeExporter]

This appears to work fine on all instruments on all difficulties for both RB 
and GH
style markings.  Neat.

Original comment by chris.paiano@gmail.com on 22 Nov 2008 at 7:17

• Changed state: Fixed

[GoogleCodeExporter]

Fretters' note on marking Overdrive and Starpower sections, with future Solo 
Section
marking in mind:

I would highly recommend you create any Starpower sections as Overdrive 
sections, as
FoFiX interprets them exactly the same.  Starpower sections would usually be 
marked
on note G8; Overdrive sections are marked on G#9.  In Rock Band, solo sections 
are
marked on G8.  

This means that if you mark starpower on G8, you will ONLY be able to designate
GUITAR SOLOS using the old TEXT EVENT (GH1 style) or SECTION EVENT (original 
FoFiX
RB1 style) methods.

That is why I recommend marking starpower or overdrive on G#9.  Then, should you
decide later that you want to mark out some DRUM SOLOS or BASS SOLOS -- you 
will be
able to add those on G8.  (will be supported in FoFiX soon!)

Original comment by chris.paiano@gmail.com on 26 Nov 2008 at 3:30

[GoogleCodeExporter]

Original comment by chris.paiano@gmail.com on 3 Jan 2009 at 2:38

• Added labels: Milestone-Release-3.100