Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

MIDI Input handling chokes on massive synchronization events #1175

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Since FoFiX currently only handles one midi event per frame, when an
external midi device sends a lot of midi timing synchronization events, a
backlog occurs, causing massive delays on controller input and eventually
dropped events.

A simple fix is to surround the midi handling code in input.py with a loop
that exits when there are no more midi events pending.  I have patched
3.120 and 3.121 in this manner and it has completely resolved the problem.

Attached is my diff on input.py.

Original issue reported on code.google.com by DNSchneid@gmail.com on 16 Apr 2010 at 10:17

Attachments:

GoogleCodeExporter commented 8 years ago
Bumping priority and adding Review label.

Original comment by fuzio...@gmail.com on 1 Sep 2010 at 1:27

GoogleCodeExporter commented 8 years ago
I can confirm both the issue and that the patch fixes it when using a Yamaha 
PSR-E413 keyboard (with internal USB-MIDI adapter) on Gentoo Linux stable with 
a genkernel kernel.

Original comment by stephan....@gmail.com on 18 Sep 2010 at 7:33

GoogleCodeExporter commented 8 years ago
Added - http://bit.ly/afT1VX

Please run 'git pull' to update and let me know if you experience more problems.

Original comment by fuzio...@gmail.com on 18 Sep 2010 at 10:19