Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

One or more notes not rendered in PART DRUMS #1182

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Describe the problem. What did you expect? What do you see?
During playback of my chart, I find that FoFiX did not render a gem that
clearly exists in the MIDI.

List the steps to recreate the problem.
1. Play the chart

What version are you using? Include the FoFiX version, the Python version,
your operating system, and whether it is SVN (alpha), beta, RC, or final
release.
FoFiX 3.121 Final (py2.6 ogl3)

Did you read the wiki on how to report bugs, conveniently called
ReportingBugs? If this is a bug report, please include the log file!
Log file: http://www.sendspace.com/file/dv9oqa

Please provide any additional information below.
The only thing I am aware of that may be a contributor is that when I
authored the chart in EOF, I find that the chord note immediately before
the missing yellow gem is sustained.  FoFiX might be misreading the notes
because of this, but I would consider it a defect of FoFiX, since it read
the green note but not the yellow note.

Here is the chart during playback in FoFiX:
http://i15.photobucket.com/albums/a354/raynebc/ingame.jpg

The yellow gem on that first bass note in the picture is missing.  Here is
the MIDI file when imported back into EOF, proving that the yellow gem is
present in the MIDI:
http://i15.photobucket.com/albums/a354/raynebc/inEOF.jpg

Here is a video of playback, as well as the chart files, so you can verify
the bug:
http://www.sendspace.com/file/f4t8oq

Original issue reported on code.google.com by raynebc on 24 Apr 2010 at 8:46

GoogleCodeExporter commented 8 years ago
Forgot my OS:  Windows XP Pro x64.  I am using basically all defaults besides 
using
the quick set to fastest speed, setting my song library path, defining drum
instrument, AV delay, etc.

Original comment by raynebc on 24 Apr 2010 at 8:49

GoogleCodeExporter commented 8 years ago
I have issues with EOF not rendering notes in-game occasionally. All you have 
to do
is delete the two notes in EOF, then put them back in (don't copy paste, put 
them in
manually). After that, both notes should display in-game. When you delete them 
you'll
notice that they don't delete at the same time. Only one of them will delete, 
then
other will if you press delete again after selecting it. I have no idea why this
happens, but it's definitely something that I come across every once in a 
while. Hope
this helps.

Original comment by alanstr...@gmail.com on 17 May 2010 at 5:16

GoogleCodeExporter commented 8 years ago
I don't believe that's the source of this particular issue, especially when the 
only
missing drum notes were immediately after a sustained drum "chord" that 
extended up
to it.

Original comment by raynebc on 17 May 2010 at 7:39

GoogleCodeExporter commented 8 years ago
I'm confused, I didn't explain a source.. I gave a possible solution.. Are you 
saying that the solution didn't 
work for you?

Also, this seems more like EOF screwing up than FoFix displaying notes 
incorrectly. I could be wrong 
though.

Original comment by alanstr...@gmail.com on 18 May 2010 at 4:02

GoogleCodeExporter commented 8 years ago
As somebody who writes MIDI software, I am quite certain that the workaround you
suggested won't fix the problem in FoFiX if the problem is what I believe it to 
be. 
Deleting the notes and placing them again in EOF would generally place the 
notes so
that they do not extend all the way to the next drum "chord".  While this would
almost certainly prevent FoFiX from mis-reading the chart, FoFiX should be able 
to
properly read the MIDI and not skip the notes even if the PART DRUMS track has
sustained notes.

Original comment by raynebc on 18 May 2010 at 4:28

GoogleCodeExporter commented 8 years ago
FoFix is built to handle sustains in the drum part or EOF is removing them when 
the midi is generated 
(I'm sure you'd know whether the second one was true). One of the two.

Don't discredit my suggestion unless you have tried it. It sounds stupid but it 
has fixed every issue I've 
encountered with notes showing up in the editor yet not in game.

Also, I'd have loved to test it myself, but I get an "Error - No Song" even 
though all files are present..

Try it. If it doesn't work I'll go away. ^_^ 

Original comment by alanstr...@gmail.com on 18 May 2010 at 5:25

GoogleCodeExporter commented 8 years ago
Actually, forget it. I'm unprepared to help in this situation (should've done my
homework before I first resonded). I just realized I have an older version of 
EOF. I
was able to load your song and verify that that was not the issue with the 
updated
version of EOF. Sorry for wasting your time.

Hopefully someone with a bit more knowledge on the inner workings of FoFix will 
help
you out. Have a good one! :)

Original comment by alanstr...@gmail.com on 18 May 2010 at 2:01

GoogleCodeExporter commented 8 years ago
Thanks for the sentiment.  The fact that loading the MIDI showed that the MIDI 
did
contain all notes as expected was what leads me to believe that FoFiX isn't 
parsing
the MIDI correctly in some situations.

Original comment by raynebc on 18 May 2010 at 2:38

GoogleCodeExporter commented 8 years ago
Bump.  MIDI parsing errors are a rather important thing to fix.

Original comment by raynebc on 3 Jul 2010 at 6:07

GoogleCodeExporter commented 8 years ago
Issue set to invalid due to one or more of the following reasons:
1) Age. This issue is considered abandoned.
2) Unrelated. The issue isn't related to FoFiX.
3) Fluke. The issue cannot be reproduced or was fixed long ago. (AKA: It's just 
you.)

Feel free to reply if you are certain the issue still exists and is relevant to 
FoFiX.

Original comment by fuzio...@gmail.com on 1 Sep 2010 at 2:31

GoogleCodeExporter commented 8 years ago
I don't have the means to test this on the current Git/SVN release of FoFiX, 
but this issue should certainly not be marked invalid unless you can confirm 
the current release works correctly.  I was able to reproduce this multiple 
times in 3.121 final.

Original comment by raynebc on 1 Sep 2010 at 2:52

GoogleCodeExporter commented 8 years ago
Reopened and marked with higher priority. Will investigate.

Original comment by fuzio...@gmail.com on 1 Sep 2010 at 3:01

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
EOF has been modified to write all drum notes with a length of 1 ms.  This 
should prevent more problematic charts from being created, but won't do 
anything for FoFiX's ability to play existing charts or charts created from 
other editors.  Here's the example chart, re-saved from the current development 
version of EOF (in case it helps testing):

MIDI only:
http://www.sendspace.com/file/oly535
Entire chart:
http://www.sendspace.com/file/4ux81v

Original comment by raynebc on 12 Sep 2010 at 6:01

GoogleCodeExporter commented 8 years ago
Bump to avoid automatic ticket closure.

Original comment by raynebc on 18 Jul 2011 at 10:33