search

Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

FoFiX doesn't correctly read lyric phrases that don't implement padding #1203

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
As reported here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=32725&start=735#p536496

As I mentioned, Harmonix indicates that padding at the beginning and end of a 
lyric phrase is not required:
http://creators.rockband.com/docs/Vocal_Authoring#Phrasing

FoFiX would benefit from being updated to correctly read lyric phrases, even if 
the Note 105/106 On was 0 delta ticks away from the first lyric in the phrase.

Original issue reported on code.google.com by raynebc on 9 Jul 2010 at 11:08

GoogleCodeExporter commented 9 years ago 
Added WishList type and lowered priority.

Original comment by fuzio...@gmail.com on 1 Sep 2010 at 2:22

GoogleCodeExporter commented 9 years ago 
So we can code a padding workaround in EOF, could you please indicate how much 
padding FoFiX would need to read a vocal chart correctly?  Would 1 delta 
between a lyric phrase marker and the first lyric in that line be sufficient?

Original comment by raynebc on 1 Sep 2010 at 4:31

GoogleCodeExporter commented 9 years ago 
This might have also been caused in cases where the first lyric in a phrase was 
defined after the lyric phrase on marker, even though they were at the same 
delta time.  EOF's behavior has been altered to ensure the vocal track will 
never be written this way, but if you can check if padding is actually 
necessary, we can make accommodations for that.

Original comment by raynebc on 1 Sep 2010 at 6:52

GoogleCodeExporter commented 9 years ago

Original comment by fuzio...@gmail.com on 2 Sep 2010 at 2:20

GoogleCodeExporter commented 9 years ago 
Not sure why this is still categorized as "wish list", considering it's 
technically a defect, as per Harmonix documentation.

Anyways, gunder confirmed that 5 deltas of padding worked fine, so I lowered 
the padding amount to 1 delta.  It remains to be seen whether this works around 
the lyric parsing bug.

Original comment by raynebc on 20 Nov 2010 at 1:24

GoogleCodeExporter commented 9 years ago

Original comment by fuzio...@gmail.com on 20 Nov 2010 at 4:24

GoogleCodeExporter commented 9 years ago 
The padding workaround in EOF wasn't working as of stable release 1.7 (r571), 
but was corrected in 574 (5 deltas of padding) and 575 (1 delta of padding).  
If the developers need to create any vocal charts for replicating this issue, 
these revisions should help.  Gunder submitted screen captures showing how this 
bug presents:
http://s13.directupload.net/file/d/2356/6i4tsl6t_png.htm

Sometimes the first lyric in the affected phrase is grayed out, and sometimes 
it is not displayed at all.  I don't know if it's actually being scored for in 
either of those cases.

Original comment by raynebc on 27 Nov 2010 at 6:29

GoogleCodeExporter commented 9 years ago 
It was indicated that 1 delta tick of padding wasn't enough, so I changed EOF's 
padding back to 5 deltas.  But this is still just a workaround to the problem.

Original comment by raynebc on 19 Jan 2011 at 7:25