Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

Pro Drums #1233

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
I was thinking...

It would be cool, and a good start, to add pro drums. It really would be the 
easiest of all the pro instruments to add, and at this point the most possible. 
It wouldn't take long to update charts to the new pro mode either which always 
a good thing. Other pro instruments could just be added at a later time, and 
likely version.

Original issue reported on code.google.com by 8Be...@gmail.com on 17 Oct 2010 at 6:54

GoogleCodeExporter commented 8 years ago
Adding support for more lanes could open up the potential for FoFiX to play 
Drum Mania charts, in addition to pro guitar/bass, which will require 6 lanes 
as a start.

Original comment by raynebc on 17 Oct 2010 at 7:29

GoogleCodeExporter commented 8 years ago
This could probably be merged into a similar issue, but I'll keep it by itself 
because its specific to RB3 support.

Original comment by fuzio...@gmail.com on 17 Oct 2010 at 8:00

GoogleCodeExporter commented 8 years ago
According to thekiwimaddog, by default, all RB3 style drum charts have green, 
yellow and blue drum gems as cymbals (requires a hit from the appropriate color 
on the RB Pro drum extension cymbal).  There are MIDI markers to override this 
so that they count as green (bass drum), yellow or blue pads instead:

Yellow drum: 110
Blue drum: 111
Green drum (bass): Note 112

These markers operate like star power markers and apply to all notes within the 
pro drum phrases.  Phase Shift is already implementing handling for this and 
EOF will support it shortly.

Original comment by raynebc on 25 Oct 2010 at 5:03

GoogleCodeExporter commented 8 years ago
I was mistaken earlier, note 112 is for drum 5 (green).  EOF now supports 
marking pro drums, and Phase Shift is implementing it as well.

Original comment by raynebc on 27 Oct 2010 at 5:38

GoogleCodeExporter commented 8 years ago
EOF and Phase Shift have implemented an INI tag that will prove to be a 
reliable way to tell if a chart that lacks tom phrases are supposed to be all 
toms or all cymbals.  If song.ini contains a "pro_drum = True" tag, then that 
means the drum track contains one or more cymbals.  It could be a good idea for 
FoFiX to support this tag when pro drum support is added, because a large share 
of RBN MIDIs, and most custom drum tracks will not have proper cymbal notation. 
 Checking for this tag will allow all tracks to be presented correctly to the 
player.

Original comment by raynebc on 24 Jun 2011 at 6:45

GoogleCodeExporter commented 8 years ago
It was easy implementing the value for the song.ini, but if you could could you 
direct me to proper documentation so then I could take a stab at writing the 
prodrums system.  Pro-guitar is a little more complex so I think I'll stick 
with working on Drums for now.

Original comment by n_hyd...@comcast.net on 24 Jun 2011 at 6:55

GoogleCodeExporter commented 8 years ago
The short version is that any lane 3, 4 or 5 drum gems within the tom markers 
are considered tom drums, otherwise they are considered cymbals.  Harmonix used 
this notation for pretty much all their drum charts starting from RB1, which is 
why they work with pro drums in RB3.  Customs and early RBN charts didn't have 
this information, so they were all made without tom markers, which is why some 
RBN songs in RB3 show up as all cymbals.

Official drum authoring documentation is here:
http://creators.rockband.com/docs/Drum_Authoring

Original comment by raynebc on 24 Jun 2011 at 7:19

GoogleCodeExporter commented 8 years ago
I'm going to lower the priority, because there are some other things that need 
to be done before this can be completed.

Original comment by matthews...@gmail.com on 13 Mar 2012 at 1:09