search

Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

Drum frets dont show hit state, and underlying code doesnt properly detect multiple hits at the same time. #1259

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.Make drum frets with a different hit state than the pressed state
2.Play a song

What is the expected output? What do you see instead?

Watch as the hit images for the frets you just made don't ever show up when 
they should.

Please use labels and text to provide additional information.

This isn't just one bug as i have looked at it before and failed to fix it.

Its several bugs that show up as this one bug. I found through digging through 
the commits that the most basic part of it was probably broke in a massive code 
comment out that effected the drum hitFlames well over 2 years ago.

I fixed that one small part of the bug but then found the second part of it. 
Once fixed only 1 button will show as being hit at a time, so even if you do 
fix one bug you need to deal with this other one to make it work correctly.

That first part is that self.hit is never changed to reflect the notes being 
hit.

The second part has to do with that self.fretActivity doesn't correctly store 
the currently being hit drum notes because it only shows 1 note at a time it 
doesn't show if 2 notes are being hit at the same time.

I would have a go at attempting to fix it again but i have been a bit more busy 
than i would hope to be right now. So i cant really look into it for very long. 
Hopefully someone else can have a crack at this for now, as it has been bugging 
me ever since i started making themes.

I don't know how the scoring system works currently so i don't know if this has 
any effect on scores or not, so that would be something good to look into as 
well.

That should be everything, at least its everything i can think of currently 
about this bug.

Original issue reported on code.google.com by matthews...@gmail.com on 19 Jul 2011 at 8:04

GoogleCodeExporter commented 8 years ago 
as a side note i only fixed that first part of the bug on my local copy and 
didn't commit it because i didn't find it worth fixing that small part of the 
larger issue if things looked worse in game.

Original comment by matthews...@gmail.com on 19 Jul 2011 at 8:07

GoogleCodeExporter commented 8 years ago 
also looking though other issues it seems things mentioned in Issue 1177 about 
bre's and freestyle sections are also a byproduct of these bugs.

Original comment by matthews...@gmail.com on 19 Jul 2011 at 8:24

GoogleCodeExporter commented 8 years ago 
so yeah today i have been spending a ton of time looking into this and have 
found out somethin

This is a very old bug the backend parts of it i have tracked down all the way 
to the hering mod which mfh ported the drums code from. so that's at least 4 
years old....

Original comment by matthews...@gmail.com on 28 Jul 2011 at 12:39