search

Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

Available versions of pyrtmidi library have broken compatability with FoFiX 3.121 #1260

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
After grabbing pyrtmidi from SVN 
(http://svn2.assembla.com/svn/pkaudio/pyrtmidi/) followed by a build/install 
FoFiX 3.121 crashed with interface errors to pyrtmidi:
  -openPort Parameters have changed
  -getMessage() returns an incompatible object than it used to so midimsg[i] would cause a runtime error.
  -midimsg is NoneType--len() not supported

The pyrtmidi project has apparently evolved and doesn't require so much low 
level MIDI processing anymore.  See attached file for examples.

List the steps to recreate the problem.
1. Download, build, install pyrtmidi from SVN
$ svn co http://svn2.assembla.com/svn/pkaudio/pyrtmidi/
$ cd pyrtmidi
$ python setup.py build
# python setup.py install
2. Connect a MIDI interface to computer (mine is  M-Audio Audiophile 2496)
3. Run FoFix and it will crash
4. Check fofix.log or run from terminal and watch stderr msgs.
 (sorry I didn't save my old logs to post here)

Version Info:
FoFix v3.121 (cloned from http://github.com/stump/fofix->master branch)
pyrtmidi Rev 36
Python 2.6.6
Debian Squeeze 2.6.39.1

I have rewritten the calls in Input.py->pyrtmidi to work with the current 
release of pyrtmidi which has changed its interface since the FoFix release 
apparently.  I see that another MIDI library is being considered for FoFix 4 
and would be glad to port the code.  Attached is the patch I am submitting for 
consideration.

Original issue reported on code.google.com by mlof...@gmail.com on 21 Jul 2011 at 1:53

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
New Diff file as promised

Original comment by mlof...@gmail.com on 21 Jul 2011 at 2:52

Attachments:

GoogleCodeExporter commented 9 years ago 
i might look into somehow applying this patch. We no longer use SVN, we 
switched git so if you can apply it to the code there i will probably push it. 
Also if you build me a windows installer that i can update the download on this 
list. I need an installer to put on the deps list.

https://github.com/stump/fofix/blob/master/doc/RunningFromSource.mkd#Setting-up-
Python-and-third-party-dependencies

https://github.com/stump/fofix - the repo link

Original comment by matthews...@gmail.com on 10 Mar 2012 at 11:34

GoogleCodeExporter commented 9 years ago 
At the time I submitted this patch I hadn't even tried running FoFix under 
Windows and was anticipating getting involved with the v4 release for my own 
selfish drumming desires.  Since then I've learned that the Windows release 
works quite nicely without this patch.  

Do you see a need for the patch at this point with v4 on semi-permanent hiatus 
and most users apparently not having problems with MIDI?  If so I'll gladly 
find time to push it through.

Original comment by mlof...@gmail.com on 11 Mar 2012 at 9:21

GoogleCodeExporter commented 9 years ago 
I think it would be a good thing to do, if i could get it to build on windows. 
If anyone can get it build and an installer made i would say go for it. I can't 
get it to build on MinGW or MSVC right now so idk.

FoFiX doesn't have to be dead, if more people joined in on development, then 
maybe it wouldn't be where it is now.

Original comment by matthews...@gmail.com on 14 Mar 2012 at 5:01