search

Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

Add theme.ini settings to position and scale "Jurgen Is Here" and "Jurgen Was Here" text #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As the title says.

Original issue reported on code.google.com by evily...@gmail.com on 23 Oct 2008 at 8:29

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 26 Oct 2008 at 1:03

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 28 Oct 2008 at 3:39

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 31 Oct 2008 at 1:38

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 12 Nov 2008 at 12:07

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 13 Nov 2008 at 9:45

GoogleCodeExporter commented 9 years ago 
http://people.clemson.edu/~hworthi/issue 33.jpg

I have created a option for text size: Big or Small, is this small and out of 
the way
enough? do we want this option to effect the text size and position in 
multiplayer too?

Original comment by Qst...@gmail.com on 2 Dec 2008 at 8:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Personally i don't think it deserves an option as i'd rather always have it 
that small...

To answer your second question, i'd also apply that to multiplayer.

Original comment by evily...@gmail.com on 2 Dec 2008 at 8:26

GoogleCodeExporter commented 9 years ago

Original comment by Qst...@gmail.com on 2 Dec 2008 at 8:29

GoogleCodeExporter commented 9 years ago 
Yeah, I'd always want it small too -- we have to leave the big option in there 
though
as some players might like it better.

It'll make for some cleaner looking demo videos with the Small option though.

As long as it can't be completely disabled, so it isn't easy to make Jurgen 
videos to
show off "your" skills.

Original comment by chris.paiano@gmail.com on 2 Dec 2008 at 8:32

GoogleCodeExporter commented 9 years ago 
Also, please be sure that the Guitar Solo accuracy and review displays don't
interfere with the new Jurgen Is Here positioning -- they change position when 
Jurgen
is playing.

Original comment by chris.paiano@gmail.com on 2 Dec 2008 at 8:33

GoogleCodeExporter commented 9 years ago 
(BTW, I'd recommend making the new "Small" setting the default option if you 
haven't
already.)

Original comment by chris.paiano@gmail.com on 2 Dec 2008 at 8:37

GoogleCodeExporter commented 9 years ago 
Here's an image link that should work correctly (so you can click instead of
copy/paste the above):
http://people.clemson.edu/~hworthi/issue%2033.jpg

Original comment by chris.paiano@gmail.com on 2 Dec 2008 at 8:38

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
thanks chris, im fooling around with some multiplayer positions, what do you 
guys
think of this

http://people.clemson.edu/~hworthi/JurgenSmall.jpg

Original comment by Qst...@gmail.com on 2 Dec 2008 at 8:55

GoogleCodeExporter commented 9 years ago 
the only thing that i could see with that one is that the song info will 
interfere at
the beginning if its long enough.

Original comment by Qst...@gmail.com on 2 Dec 2008 at 8:58

GoogleCodeExporter commented 9 years ago

Original comment by Qst...@gmail.com on 2 Dec 2008 at 8:59

GoogleCodeExporter commented 9 years ago 
Assuming it used to be centered, it's no longer centered?!

(Qstick, see your gmail inbox, if you reply we'll be able to chat in order to 
avoid
issue threads to become huge dialogs.)

Original comment by evily...@gmail.com on 2 Dec 2008 at 9:02

GoogleCodeExporter commented 9 years ago 
I think that'll work, in any case the people have the choice to go back to the 
old
big style if they don't like it :)

Original comment by chris.paiano@gmail.com on 2 Dec 2008 at 9:25

GoogleCodeExporter commented 9 years ago 
fixed in r501

Original comment by Qst...@gmail.com on 2 Dec 2008 at 9:59

GoogleCodeExporter commented 9 years ago 
I like the newer small size. Makes nicer looking demo's for me when i make 
them.

Original comment by worldr...@hotmail.com on 3 Dec 2008 at 4:00

GoogleCodeExporter commented 9 years ago 
As I was running tests for the new MIDI solo system, I took this screenshot:

http://i33.tinypic.com/10ppxs3.jpg

Scrolling lyrics are now partially obscured by the new Jurgen text.

Original comment by chris.paiano@gmail.com on 7 Dec 2008 at 2:29

GoogleCodeExporter commented 9 years ago 
good catch, are you gonna take care of this fix or would you like me to bring 
it down
some, i know you are working in guitarscene pretty heavily aren't you?

Original comment by Qst...@gmail.com on 7 Dec 2008 at 4:14

GoogleCodeExporter commented 9 years ago 
Yeah wait until the new MIDI solo system is in place.  Won't be long.

Original comment by chris.paiano@gmail.com on 7 Dec 2008 at 4:45

GoogleCodeExporter commented 9 years ago 
fixed r618

Original comment by Qst...@gmail.com on 21 Dec 2008 at 5:08

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 3 Jan 2009 at 2:38

GoogleCodeExporter commented 9 years ago 
needs to be moved to a corner or something out of the way of everything

Original comment by Qst...@gmail.com on 3 Jan 2009 at 8:22

GoogleCodeExporter commented 9 years ago 
Oops! A heads up here - I just realized I committed a change I had made in my 
test 
copy that affects this issue. Jurgen text/variables are now expandable, but as 
such 
the text was moved into the render player loop. It works well enough, I 
believe, but 
some more thorough testing is likely in order. Sorry if this messes with 
anything 
you were working on - and obviously feel free to change that back!

Sorry again!

Original comment by aked...@gmail.com on 9 Jan 2009 at 1:16

GoogleCodeExporter commented 9 years ago 
ok, i haven't done anything else with this, so don't worry about it.

Original comment by Qst...@gmail.com on 9 Jan 2009 at 6:04

GoogleCodeExporter commented 9 years ago 
OK I just simplified Jurgen's text rendering code, and moved that crap down to 
the
lower right corner.  Works fine for me, much better than previous.  Committed 
in r809.

Original comment by chris.paiano@gmail.com on 19 Jan 2009 at 12:50

GoogleCodeExporter commented 9 years ago 
Just wanted to give you a heads up that now that you moved the text its under 
the GH3
meter and only the J is visible.

Screenshot: http://img516.imageshack.us/img516/2903/errorlf7.png

Original comment by nickman1...@gmail.com on 20 Jan 2009 at 11:48

GoogleCodeExporter commented 9 years ago 
Maybe there should be a theme.ini setting to avoid that problem?

Original comment by mrhappen...@gmail.com on 20 Jan 2009 at 5:55

GoogleCodeExporter commented 9 years ago 
Oops!  That was unintentional :)

Yeah, a theme.ini setting would be best, allow the themers to position and 
scale this
text.

Of course, it'd be nice to enforce a minimum visible scale, and enforce screen
boundaries so that the text has to be visible somewhere... so someone can't 
just move
the text off the screen, enable Jurgen, and record a FC video to brag about :)

Original comment by chris.paiano@gmail.com on 21 Jan 2009 at 2:36

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 21 Jan 2009 at 2:37

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 21 Jan 2009 at 2:37

GoogleCodeExporter commented 9 years ago 
-.-

"and record aN FC video to brag about"

that's what I meant.

Original comment by chris.paiano@gmail.com on 21 Jan 2009 at 3:04

GoogleCodeExporter commented 9 years ago

Original comment by worldrave111@gmail.com on 23 Jan 2009 at 4:24

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 7 Feb 2009 at 12:01

GoogleCodeExporter commented 9 years ago

Original comment by chris.paiano@gmail.com on 7 Feb 2009 at 12:23

GoogleCodeExporter commented 9 years ago

Original comment by Qst...@gmail.com on 9 Feb 2009 at 12:09

GoogleCodeExporter commented 9 years ago 
fixed r951

Original comment by Qst...@gmail.com on 9 Feb 2009 at 1:01

GoogleCodeExporter commented 9 years ago 
It appears to crash when there is no jurgen text definition in the theme.ini 
file...
no default fallback?

Original comment by chris.paiano@gmail.com on 9 Feb 2009 at 1:45

GoogleCodeExporter commented 9 years ago 
hmm thought i put one in, let me look

Original comment by Qst...@gmail.com on 9 Feb 2009 at 1:47

GoogleCodeExporter commented 9 years ago 
i see the problem, fixed in 5 min

Original comment by Qst...@gmail.com on 9 Feb 2009 at 1:48

GoogleCodeExporter commented 9 years ago 
  File "X:\Games\FretsOnFire\FoFiX\src\Session.py", line 66, in signalMessage
    handler.handleMessage(sender, message)
  File "X:\Games\FretsOnFire\FoFiX\src\Session.py", line 87, in handleMessage
    return f(sender, **message.__dict__)
  File "X:\Games\FretsOnFire\FoFiX\src\World.py", line 248, in handleSceneCreate
d
    scene = SceneFactory.create(engine = self.engine, name = name, owner = owner
, session = self.session, **args)
  File "X:\Games\FretsOnFire\FoFiX\src\SceneFactory.py", line 40, in create
    return getattr(m, name + "Client")(engine = engine, owner = owner, session =
 session, **args)
  File "X:\Games\FretsOnFire\FoFiX\src\Scene.py", line 223, in __init__
    self.createClient(**args)
  File "X:\Games\FretsOnFire\FoFiX\src\GuitarScene.py", line 227, in createClien
t
    if float(self.jurgenText[2]) < 0.00035:
IndexError: list index out of range

Original comment by chris.paiano@gmail.com on 9 Feb 2009 at 1:48

GoogleCodeExporter commented 9 years ago 
Yep its fixed.

Original comment by chris.paiano@gmail.com on 9 Feb 2009 at 1:59