FoFiX currently does not directly support unedited / raw RB or GH style MIDIs due to track order

[GoogleCodeExporter]

Need specifics, but apparently track order has to be edited for FoFiX to
recognize the parts correctly.

Song.py needs a new type of Part class with the unedited RB MIDI track
order, and initialization should detect when this new class needs to be
used.  This would save rippers (and those that go back to ensure all MIDI
features / events are intact) a lot of effort.

Original issue reported on code.google.com by chris.paiano@gmail.com on 9 Dec 2008 at 5:53

[GoogleCodeExporter]

As posted here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=25040&p=320778#p320774

"
usually the order of unedited .mid files are

PART DRUMS
PART GUITAR
PART BASS

or sometimes

PART DRUMS
PART BASS
PART GUITAR

the problem is that FOFix reads the .mid correctly only in this order

PART GUITAR
PART BASS
PART DRUMS
"

Original comment by chris.paiano@gmail.com on 9 Dec 2008 at 6:15

[GoogleCodeExporter]

I haven't seen any in the RB DLC mids yet, but I know they are there in GH3/GHA 
and
will be there in GHWT. 

PART GUITAR_COOP

I have attached an image so you can have a visual reference to as how they 
appear and
what we have been working with.

This process is fairly easy, just tedious. I open the unedited mids in Cakewalk 
Sonar
7, There are almost always 7 tracks. I have seen some that have 8 tracks in 
them.

PART DRUMS
PART BASS
PART GUITAR
PART VOCALS
EVENTS
VENUE
BEAT

and sometimes
MY VENUE

Harminox likes to mix it up on the track order they put the first three tracks 
in.
The last four/five tracks are ALWAYS in the same order.

I'll have to do some more investigating into unedited GH/GH2/GH80/GH3/GHA mids 
to see
if there is anything else to worry about.

Original comment by mrfa...@gmail.com on 9 Dec 2008 at 7:07

Attachments:

• midi.jpg

[GoogleCodeExporter]

Excellent, I've updated the issue to encompass GH and RB style MIDIs.  I'm sure 
I'll
be able to figure something out to remove the need for this tedious process.

Original comment by chris.paiano@gmail.com on 9 Dec 2008 at 8:05

• Changed title: FoFiX currently does not directly support unedited / raw RB or GH style MIDIs due to track order

[GoogleCodeExporter]

Attempting to work on this while my laptop is behaving....

Original comment by chris.paiano@gmail.com on 12 Dec 2008 at 2:25

• Changed state: Started

[GoogleCodeExporter]

so far, the unedited MIDIs seem to work just fine with the track order. I've 
looked
through Song.py where I worked on the track identification code before, and
simplified it a bit -- but didn't change any logic so it should be the same as
before. I swapped the unedited notes.mid in for Synchronicity II (RB1DLC) and 
the
drum track is indeed first. It let me play guitar and drums (I also let Jurgen 
play
drums on expert) and everything seemed fine.

I'll keep testing other songs randomly until I see a problem, and will check my 
new
log entries attached to the Log MIDI Sections option which show which sequences 
are
recognized as which parts... but so far so good. I am committing this new code 
now as
r600.

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 6:47

[GoogleCodeExporter]

Is the problem just that empty Rhythm Guitar and Lead Guitar parts show up?  
Because
I just tested every single part on RB1DLC - Can't Stand Losing You and that's 
all I
could see as being wrong... if so this is a very minor problem.  

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 7:00

[GoogleCodeExporter]

Same problem confirmed on RB1DLC - Roxanne with unedited MIDI...

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 7:08

[GoogleCodeExporter]

so we have to rename all the midi's for this to work?

Original comment by slan...@gmail.com on 19 Dec 2008 at 7:08

[GoogleCodeExporter]

I'll add an option to use notes-unedited.mid instead of notes.mid where 
available, so
everyone can test just by downloading and extracting MrFaust's update packs.

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 7:14

[GoogleCodeExporter]

Committed changes in r601:
New debug setting "notes-unedited.mid" : Auto (default), Off
New log setting "Log Unedited MIDIs" : Off (default), On

Caution!  This revision enables usage of "notes-unedited.mid" files instead of
"notes.mid" by default, if available.  This seems to work fine for me so far 
but this
rev should flush out which songs (if any) still have problems with track 
ordering.

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 7:54

[GoogleCodeExporter]

seems to be working great :)

Original comment by slan...@gmail.com on 19 Dec 2008 at 9:00

[GoogleCodeExporter]

It's working fine for RB tracks, but it seems that it makes every instrument 
track
display in the instrument choice screen instead of only the ones in the MIDI. 
So you
have to choose from every possible instrument.

Original comment by evilbobt...@gmail.com on 19 Dec 2008 at 10:17

[GoogleCodeExporter]

Instrument filtering should be fixed in r602.

Original comment by chris.paiano@gmail.com on 19 Dec 2008 at 10:21

[GoogleCodeExporter]

Yes, its fixed now in both GH and RB songs.

Original comment by evilbobt...@gmail.com on 19 Dec 2008 at 10:26

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This seems to be working fine as of r602.  

Original comment by chris.paiano@gmail.com on 20 Dec 2008 at 9:46

• Changed state: Fixed

[GoogleCodeExporter]

There is a small problem with Blue Öyster Cult - (Don't Fear) The Reaper 
guitar on
expert. It almost works, but the first couple notes are bonkers.

Original comment by MofoMan2...@gmail.com on 22 Dec 2008 at 7:54

[GoogleCodeExporter]

I doubt it is related. Don't fear the reaper was borked before FoFiX even hit 
3.0.

I have similar issues with it, except on top of the weird notes at the begining 
the
song keeps getting worse, and then there are no notes at all. 

The game reports the song as longer than it should be as well.

As I said, I doubt this is related, as I noticed it in the 2.90 days. I just 
forgot
to mention anything about it.

Original comment by lysdestic@gmail.com on 24 Dec 2008 at 5:30

[GoogleCodeExporter]

Original comment by chris.paiano@gmail.com on 3 Jan 2009 at 2:38

• Added labels: Milestone-Release-3.100