Encores unlocking incorrectly due to inability to add more than one unlock_require

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Installing a career mode eg.
http://www.fretsonfire.net/forums/viewtopic.php?f=5&t=32009&st=0&sk=t&sd=a
2. Beating final song in tier without beating other songs
3. Encore is unlocked

What is the expected output? What do you see instead?
Encore should not be unlocked until all songs in tier have been completed

Please provide any additional information below.
This is due to FOF only being able to handle one entry in the
unlock_require field of the song.ini. Being able to add multiple unlock
indexes would negate this problem.

Attached is a song.ini which exhibits this problem.

Original issue reported on code.google.com by redion1...@gmail.com on 1 Jan 2009 at 1:15

Attachments:

• song.ini

[GoogleCodeExporter]

Quote from forums (slightly modified for better translation to English):

Having a number at the left of a song title, with an unlock_id set for the same 
code
for all songs in a tier, eg. gh1_1 (all tier 1 songs), gh1_1enc (Encore)
gives the proper results, in that all songs in a tier must be completed before 
the
song is unlocked.

If the unlock_id is separate for each song, eg. gh1_1.1, gh1_1.2, gh1_1.3, 
gh1_1.4
and gh1_1enc, and the encore song.ini lists the unlock_require as being gh1_1, 
the
song is automatically unlocked, as there are no songs with that exact 
unlock_id. The
current workaround is to set the unlock_require = gh1_1.4, however this means 
that
only the fourth song (in this case, Smoke on the Water) must be played to 
unlock the
encore. This means that people could theoretically complete the GH:80s career by
playing 12 songs, instead of the 30 included.

http://www.fretsonfire.net/forums/viewtopic.php?f=5&t=32009&p=331303&hilit=+unlo
ck+require#p331402

Original comment by redion1...@gmail.com on 7 Jan 2009 at 9:55

[GoogleCodeExporter]

You can make it so all the regular tier songs have the same unlock id, and then 
you
must complete those songs to complete the tier, as the unlock require will be 
that
unlock id.

However, I think what you're also saying is that you want to keep the sequence 
of the
original game tier ordered? So that's why you're suggesting the unlock ids are
gh_1.1, etc.

Original comment by ryanturcotte@gmail.com on 7 Jan 2009 at 6:44

[GoogleCodeExporter]

No - this is why I wrote the logic to automatically remove any prefixes from 
song 
names (1. 2. 3. etc) so they can be listed in whatever order you want.  The 
first 
paragraph up there describes how to correctly set up a career:

"Having a number at the left of a song title, with an unlock_id set for the 
same code
for all songs in a tier, eg. gh1_1 (all tier 1 songs), gh1_1enc (Encore)
gives the proper results, in that all songs in a tier must be completed before 
the
song is unlocked."

The tier1.1 tier1.2 tier1.3 tier1.4 tier1.encore is NOT supported.

Original comment by chris.paiano@gmail.com on 7 Jan 2009 at 7:41

• Changed state: Invalid
• Removed labels: Priority-Low

[GoogleCodeExporter]

Erm, according to the wiki... 

"To order songs within a tier, use a decimal in the unlock_id. So for example, 
the
first song in the 2nd tier for Guitar Hero III (gh3_2) would be 
unlock_id=gh3_2.1 .
The 2nd would be gh3_2.2, and so on. But make sure all the songs are done this 
way."

http://code.google.com/p/fofix/wiki/CareerTitlesIniInstructions

This is how I choose to do them... because currently, the prefixes are not 
stripped
from the name on some menus, including the selection of instruments and 
difficulties.

Original comment by redion1...@gmail.com on 8 Jan 2009 at 1:55

[GoogleCodeExporter]

Then the Wiki needs to be updated... thank you.

The song number prefix should be stripped everywhere... what version are you 
using,
and could you provide a screenshot for every place that the prefix needs to be
stripped?  That should be a separate issue if it is not already.

Original comment by chris.paiano@gmail.com on 8 Jan 2009 at 2:01

• Changed state: New

[GoogleCodeExporter]

Also, I realize that several careers have been released with this problem, but 
the
unlock system wasn't designed to be used for sorting.  

If one of the other coders wants to add support for this type of tier sorting, 
feel
free to take ownership of this issue... I'm not volunteering for this task :)

Original comment by chris.paiano@gmail.com on 8 Jan 2009 at 2:05

[GoogleCodeExporter]

OK, after reviewing these menus that I described earlier, it appears the 
problem has
been fixed in or before the latest beta.

I would personally consider this issue closed - I now have no qualms about 
using the
numerical prefix to set up sorting, short of its effect on the uploaded scores.

Original comment by redion1...@gmail.com on 8 Jan 2009 at 2:13

[GoogleCodeExporter]

Original comment by fuzio...@gmail.com on 2 Sep 2010 at 7:45

• Changed state: Fixed