Add Big Rock Ending guitar / bass sound mode option

[GoogleCodeExporter]

option: BRE sounds - "Orig Tracks" (default), "6 Sounds" (including open
strum sound, theme or song specific), or "Random solo" (will play random
guitar solo instead of guitar track from bresolo1.ogg bresolo2.ogg
bresolo3.ogg etc, theme or song specific)

Original issue reported on code.google.com by chris.paiano@gmail.com on 4 Jan 2009 at 9:20

[GoogleCodeExporter]

For option "6 Sounds", from a discussion with my sister (a guitar player) using
ACDC's live TNT track as the example:

"
A G E
D E G Bb A
in that order
that is the lick they are playing

if you LAND on the E note
that is the "final" sounding note
you dig?
(the key the song is IN is usually the note to end on)
"

Good info for this... also, the 5 notes to pull from to create chord sounds 
will be
separate from the "lick" notes (for single notes).

Original comment by chris.paiano@gmail.com on 16 Jan 2009 at 10:03

[GoogleCodeExporter]

"
so a good ending lick would be (very basic mind you):
A, G, E
D, E, G, Bb, A .... E!
"

Original comment by chris.paiano@gmail.com on 16 Jan 2009 at 10:05

[GoogleCodeExporter]

I will be experimenting with the rtmidi module's Output functions in order to 
find
the wavetable or MIDI synth channel and attempt to play notes during guitar 
freestyle
sections...

Original comment by chris.paiano@gmail.com on 16 Jan 2009 at 11:22

[GoogleCodeExporter]

Basic MIDI output support & test code (disabled) committed in r790.

Original comment by chris.paiano@gmail.com on 16 Jan 2009 at 11:44

[GoogleCodeExporter]

I'm thinking the "6 notes" option will allow for custom freestyle note 
specification
(along with specifying which general MIDI instrument sound to use) through a 
special
"freestyle.mid" file.

The first 6 notes on the first track will be used as the freestyle notes.  
First note
will play for first fret, second note for second fret, third note for third 
fret,
fourth note for fourth fret, fifth note for fifth fret, and sixth note for open 
strums.

Hopefully I can also get the program to read the selected instrument (patch) so 
I can
let the fretter specify which guitar sound should be used for freestyle 
sections.

Eventually also add support for a similar feature for Bass parts (second track 
first
6 notes & instrument patch)

Original comment by chris.paiano@gmail.com on 17 Jan 2009 at 12:06

[GoogleCodeExporter]

Also, the default "Rock Band" style BRE sound option needs to be coded as it 
was not
a part of the original issue 108 (the BRE audio track plays uninterrupted no 
matter
how long you don't hit any notes)... so BRE input timeout and track fading 
needs to
be implemented first, and then some of these other options can be tried.

Original comment by chris.paiano@gmail.com on 18 Jan 2009 at 2:24

[GoogleCodeExporter]

Also need logic to ensure that the BRE starts with full track volume; 
currently, if
you mess up just before a BRE then the entire BRE will be silent from that 
muting.

Original comment by chris.paiano@gmail.com on 31 Jan 2009 at 4:14

[GoogleCodeExporter]

(MIDI freestyle sounds and individual OGG freestyle sounds for the frets will be
selections in the user option... or will automatically be recognized when 
included
with a song)

Original comment by chris.paiano@gmail.com on 6 Feb 2009 at 6:02

[GoogleCodeExporter]

Also, if specified, different notes can be used to play freestyle "chords".  If 
not
specified, the same single notes used for freestyle will be played for freestyle
"chords".  This will be handled on a song by song basis.

Original comment by chris.paiano@gmail.com on 6 Feb 2009 at 6:04

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

The whole BRE sound option thing for guitar & bass will be highly 
song-dependent. 
Fretters will be able to specify what type of BRE sound options are supported, 
and
players will be able to enable or disable which BRE sound options they like to 
use. 
This is still highly conceptual, but after 3.100 is out and the optimizations 
from
issue 438 are in place, work on this can begin.

Original comment by chris.paiano@gmail.com on 6 Feb 2009 at 6:17

[GoogleCodeExporter]

Just as an observation, you'd have to be careful with implementing the MIDI 
notes as
solo sound identifier. The issue being that in solos (especially blues), off-key
(blue) notes are really what bring the color of the sound out - these notes 
(flat
5/tritones, blues 7th, flat 3) are essential to a quality blues solo but can't 
be
emphasized as they are inherently dissonant.

As an example in TNT - that entire "G" chord is blue - the key/root/I is E, 
which
should be E/G#/B, but the song plays a G major chord - G/B/D with both a flat 3
(G#->G) and a flat 7 (D#->D). The Bb that adds to the solo is your flat 5 
(played as
a sharped 4)/tritone off the root (E). You'll note they never really sit on that
chord, and what works in the song is that it's so far out of place - you can't 
help
but sort of tumble into the waiting A (which is the standard IV - if you mess 
around,
there's nowhere really for you to go from the G except to the A. You could go 
to D,
but that would move the key to either D or A with II and VII chords, both 
slightly
blue). MIDI note reading could ostensibly work with intense rock solos where the
notes don't matter all that much, but particularly in blues guitar there would 
need
to be a fair amount of logic to comprehend proper musical theory.

In short? A solo in TNT too heavy on the Bb or G would sound pretty weak.

Of course, this would be ridiculously awesome to get working right.

Original comment by aked...@gmail.com on 6 Feb 2009 at 8:21

[GoogleCodeExporter]

Good info; I plan to just get the functionality coded and debugged, so that 
fretters
and others can start trying the various options out.  Not everything they come 
up
with will be gold, but eventually some guidelines will be written to help from 
that
end.  I don't plan to spend much time actually messing with which notes are 
used and
such, just to get this implemented :)

Original comment by chris.paiano@gmail.com on 6 Feb 2009 at 8:37

[GoogleCodeExporter]

Issue 593 has been merged into this issue.

Original comment by chris.paiano@gmail.com on 25 Feb 2009 at 1:50