Gamer125 / fofix

Automatically exported from code.google.com/p/fofix
0 stars 0 forks source link

Rock Band POV #583

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Play with a Rock Band theme

What is the expected output? What do you see instead?
http://img22.imageshack.us/img22/8161/rb2pov.jpg

What version of the product are you using? On what operating system?
FoFiX Windows SVN r1080

Please provide any additional information below.
Should be fixed in source like what worldrave did with the POV for GH themes.

Original issue reported on code.google.com by nickman1...@gmail.com on 21 Feb 2009 at 7:44

GoogleCodeExporter commented 9 years ago
You can adjust this yourself with the 6 custom POV settings for use in 
theme.ini --
see the Wiki page for theme.ini settings.

Add these 6 settings to a rock band theme.ini and play with them until you get 
it to
look just right (since you obviously know exactly what it should look like) - 
then
post the settings here or in the development thread.  I'll add them to my Rock 
Band 1
theme's next patch, and I would imagine that someone would add them to the Rock 
Band
2 theme as well.

Original comment by chris.paiano@gmail.com on 21 Feb 2009 at 7:47

GoogleCodeExporter commented 9 years ago
http://code.google.com/p/fofix/wiki/ThemeFileSettings

Note for 6 POV items below  If you have ALL 6 of these settings in your 
'theme.ini',
AND you are not specifying "rmtype = 3" (for GH:WT rockmeter, which requires 
special
positioning), then "Custom" POV will be forced.
pov_target_x = 0.0  Controls Custom POV. -Wiki WIP. Animated image Example -
http://img98.imageshack.us/img98/5323/exampledx9.gif
pov_target_y = 0.0  Controls Custom POV. -Wiki WIP. Animated image Example -
http://img98.imageshack.us/img98/2541/examplecb3.gif
pov_target_z = 3.7  Controls Custom POV. -Wiki WIP. Animated image Example -
http://img140.imageshack.us/img140/323/examplezh4.gif
pov_origin_x = 0.0  Controls Custom POV. -Wiki WIP. Animated image Example -
http://img73.imageshack.us/my.php?image=exampleef7.gif
pov_origin_y = 2.9  Controls Custom POV. -Wiki WIP. Animated image Example -
http://img88.imageshack.us/img88/4791/examplepy6.gif
pov_origin_z = -2.9 Controls Custom POV. -Wiki WIP. Animated image Example -
http://img140.imageshack.us/img140/4686/examplezv4.gif

Original comment by chris.paiano@gmail.com on 21 Feb 2009 at 7:48

GoogleCodeExporter commented 9 years ago
Yeah i know but i thought that it would be more correct to change it in the 
source
and set the default values for RB themes right. So that all RB themes looks 
correct.

The theme.ini settings should be used as custom POV for both GH and RB themes.

I only thought this because worldrave didn't use those settings in his GH3 skin 
but
he changed the source. And it made more sense to me that way.

Original comment by nickman1...@gmail.com on 21 Feb 2009 at 8:18

GoogleCodeExporter commented 9 years ago
Just an extra info:

The change to looks like it should be here in guitarscene.py function
def setCamera(self)

elif self.pov == 5: #Blazingamer theme-dependant
if self.rmtype == 0:
elif self.rmtype == 1:
elif self.rmtype == 2:
if self.rmtype == 3:

rmtype 2 is RB themes right ?

As to the values i can't help you there. Sorry. Im no good with thinking in 3D 
:)
Just thought i would make an issue and a forum post to see if someone else with 
more
skills could do this.

Original comment by nickman1...@gmail.com on 21 Feb 2009 at 8:24

GoogleCodeExporter commented 9 years ago
Sorry for spamming comments here but could this be a bug ?.

Shouldn't this be the same ? If i select GH3 in settings menu as POV it's not 
the
same as if FoFiX detects a theme as a GH3 theme.

if self.pov == 1:
  self.camera.target    = (0.0, 3.4, 2.8) #kk69:More like GH3
  self.camera.origin    = (0.0, 2.8*self.boardY, -3.6)

elif self.pov == 5: #Blazingamer theme-dependant
   elif self.rmtype == 1:
        self.camera.target    = (0.0, 0.6, 4.4) #Worldrave - Perfected the proper GH3 POV
        self.camera.origin    = (0.0, 3.5*self.boardY, -3.8)

Original comment by nickman1...@gmail.com on 21 Feb 2009 at 10:38

GoogleCodeExporter commented 9 years ago
Wish there was an edit button :P

It seems like FoFiX doesn't care about the theme.ini settings.
I put this in:
pov_target_x = 0.0
pov_target_y = 0.6
pov_target_z = 4.4
pov_origin_x = 0.0
pov_origin_y = 3.5
pov_origin_z = -3.8

That is worldraves values for GH3 and they should be alot diffrent then RB2 but
nothing changes. I have setting "Point of view" in settings to Theme.
But that only means use deafult settings for GH/RB/GHWT as i understand the 
source.

FoFiX should ignore any settings if all abowe values is in theme.ini right ?
But i don't think it works.

Original comment by nickman1...@gmail.com on 21 Feb 2009 at 10:53

GoogleCodeExporter commented 9 years ago
Comment 5 has been fixed by Worldrave.

Comment 6 is still valid. Setting POV in theme.ini doesn't. Atleast not for me.

My numbers for Rock Band POV is this. Don't know what others think but i find it
close to right. Only the fade distance is wrong.

pov_target_x = 0.0 
pov_target_y = 0.5 
pov_target_z = 2.35 
pov_origin_x = 0.0
pov_origin_y = 3.4
pov_origin_z = -2.85

or in source:
elif self.rmtype == 2: 
      self.camera.target    = (0.0, 0.5, 2.35) #nickman - Closer to RB POV
      self.camera.origin    = (0.0, 3.4*self.boardY, -2.85)

If no change is done to:
elif self.pov == 2: #Racer
      self.camera.target    = (0.0, 0.0, 3.7)
      self.camera.origin    = (0.0, 2.9*self.boardY, -2.9)

then users can try the new POV and if they dont like it change to RB POV in 
fretboard
settings and get the old back... (or maybe switch them around donno which is 
best)

Original comment by nickman1...@gmail.com on 23 Feb 2009 at 10:43

GoogleCodeExporter commented 9 years ago
Issue set to invalid due to one or more of the following reasons:
1) Age. This issue is considered abandoned.
2) Unrelated. The issue isn't related to FoFiX.
3) Fluke. The issue cannot be reproduced or was fixed long ago. (AKA: It's just 
you.)

Feel free to reply if you are certain the issue still exists and is relevant to 
FoFiX.

Original comment by fuzio...@gmail.com on 2 Sep 2010 at 1:39