Invalid number of total Notes - wrong hit percentage

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Play a song on drums

2. 98% of the time the total number of notes will be calculated the wrong
way - because of this, you get 100% notes hit even though you missed (note:
NOT overhit!) many, or you get 99% even though you didn't miss a single note.

3. Happens in songs that have BRE and also in songs that don't have em.
Only noticed this in Rock band + Rock band 2 songs, i.e. songs that have
drum fills.

I added a screenshot to make it easier to understand - it's physically
impossible to have a situation like in the screenshot - only if you missed
the few first notes of the song, which I can assure you I didn't.

http://img19.imageshack.us/i/wthfpr.jpg/

Original issue reported on code.google.com by Sven.Jat...@gmx.de on 13 Aug 2009 at 4:11

[GoogleCodeExporter]

Here's another example ... this is the fifth time it's happened to me today.

http://img269.imageshack.us/i/wtf2e.jpg/

Original comment by Sven.Jat...@gmx.de on 15 Aug 2009 at 5:01

[GoogleCodeExporter]

So uh ... is anyone at least noticing this?

Original comment by Sven.Jat...@gmx.de on 21 Aug 2009 at 8:21

[GoogleCodeExporter]

yea I recently managed to hit all the notes while playing drums and it said 4 
missed
notes but since I usually don't get 100% its hard to know how accurate it is 
most of
the time, maybe if there was a missed note counter that could be displayed while
playing it'd help identify where its happening?

Original comment by knap...@gmail.com on 21 Aug 2009 at 10:29

[GoogleCodeExporter]

Alright, I understand this does not seem important to the developers. Then 
please at
least show me in some way that you even discovered this post of mine.

Original comment by Sven.Jat...@gmx.de on 22 Aug 2009 at 8:45

[GoogleCodeExporter]

What do you mean "...it's physically
impossible to have a situation like in the screenshot..."  It looks possible to 
me.
I haven't had a chance to check whether this happens for me, though.  I don't 
have a
drum set and can't play on the keyboard very well.

What version of FoFiX are you using?  Does the latest svn do the same thing?

Original comment by edelstah...@gmail.com on 22 Aug 2009 at 10:39

[GoogleCodeExporter]

LIke I said, there's only one possible way to have this situation - missing the 
first
few notes, but I did not miss them. Hence, impossible.

Imagine this: I'm playing the song regularly, hitting every note, going crazy 
during
the fills, sometimes hitting the final note, sometimes leaving it out ... just
standard gameplay. Then, until the end, I hit every single note, yet the game 
tells
me (through the counter I have activated in the upper-left corner of the 
screen) that
there are still notes to come, even though the song is over. 

This makes it look like 1400/1405in the end, making it look like I missed 5 
notes.

Latest SVN doesn't fix it for me.

Original comment by Sven.Jat...@gmx.de on 23 Aug 2009 at 6:36

[GoogleCodeExporter]

Any comment from the developers?

Original comment by Sven.Jat...@gmx.de on 28 Aug 2009 at 6:24

[GoogleCodeExporter]

Is this that issue of the notes under the drum fills being deducted from the 
overall
score?

I remember that from a long time ago, I think.

Original comment by lysdestic@gmail.com on 28 Aug 2009 at 9:33

[GoogleCodeExporter]

I wouldn't know, but it's probably related to that.

They are definitely deducted from the total number of notes, that's for sure, 
since I
have the in-game note counter in the top right corner that shows it.

But it would seem that somehow it deducts more notes than it should ... that's 
what
it looks like.

Original comment by Sven.Jat...@gmx.de on 29 Aug 2009 at 8:48

[GoogleCodeExporter]

Any Update? Invalid, being thought about, being fixed?

Original comment by Sven.Jat...@gmx.de on 30 Aug 2009 at 9:26

[GoogleCodeExporter]

I really can't say. I'm not in a position to test at the moment (extremely busy
lately) and none of the main devs have put too much input on this.

The biggest thing that could help right now is more troubleshooting. Exact 
scores,
songs they occurred with, how many BRE's, drum fills, and Jewel Notes did you
have/activate, and a compare contrast on notes hit with drum fills and without -
things like this.

The more info like that we have to go on, the easier this is to track down.

The status isn't invalid, so you have nothing to worry about there. (Though a
MoreInfo tag could be warranted) But few developers will jump in to 
troubleshoot an
issue. We test and track down the issues - they code and fix them.

Original comment by lysdestic@gmail.com on 1 Sep 2009 at 7:05

[GoogleCodeExporter]

Lys pretty much hit it on the head. As it stands, we don't really know where to 
look. Looking at the code indicates it should be working fine, but it's not. 
Given 
the amount of effort tracking down this bug would be compared to the benefit of 
having it fixed, it's still in the category of "wait for more information 
before 
proceeding". So goes the world of hobby programming.

I would recommend creating a test song that: is short; has a known number of 
notes 
that should be there; and has a known number of skipped notes - to see where 
the 
discrepancy is happening. Alternatively you could grab MFH's test fill song (I 
think 
it's http://www.mediafire.com/download.php?nsqibvjjzn2) and count up the notes 
with 
fills on and off and report the results. Then we will be more able to track 
this 
down.

Original comment by aked...@gmail.com on 8 Sep 2009 at 8:23

[GoogleCodeExporter]

Issue 919 has been merged into this issue.

Original comment by aked...@gmail.com on 8 Sep 2009 at 8:23

[GoogleCodeExporter]

I'll see if I can get that to work. I'll make a Test Song and get back at you 
as soon
as I come up with results.

Original comment by Sven.Jat...@gmx.de on 8 Sep 2009 at 1:45

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I don't know if it's -exactly- this issue, but an Issue while playing RB Co-op 
seems
to be quite the same (Quickplay seems to work fine, though).

Bullet For My Valentine - Waking The Demon (RB DLC)
2 Jurgen Players: Bass Expert, Drum Expert

Jurgen Bass Player hits all the notes: 1357/1357 notes, 100% hit percentage

Jurgen Drum player hits all the notes (but skips all notes while Overdrive 
activation
is going). Those skipped notes are simply removed from the game. Normally this 
song
would have 2029 Drum notes, Jurgen skips all Overdrive parts so the end result 
looks
like this for Drums WHILE STILL PLAYING THE SONG: 1544/1544 notes, 100% hit 
percentage

In RB Co-op all notes are combines thus both players finish the song with this:
2901/2901 notes, 100% hit percentage

Now the strange part, entering the Scoreboard after finishing the song, it 
suddenly
shows this:

Bass: 1357/1357 notes, 100% hit percentage
Drums: 1544/2029 notes, 76,1% hit percentage

So, while playing, hit percentages seem to be correct, the Scoreboard on the 
other
hand adds all those skipped notes you couldn't hit while in Overdrive activation
(because they weren't there) and reduces your hit percentage significantly.
Proof: http://www.youtube.com/watch?v=V2NJRtKjPqY

Quickplay seems to work fine, but my guess is the error could be similar while
playing BREs or something.

Original comment by RyomaFo...@googlemail.com on 23 Sep 2009 at 1:20

[GoogleCodeExporter]

Something like this happened to me on guitar a couple of times.

I have long streaks of 669 out of 670, 168 out of 169 and 640 out of 642.

Which would imply that I either missed the first note(s) or the last one(s). 
But I'm
99.9% sure that I did not.

Or I am missing something else?

Original comment by Altx1...@gmail.com on 2 Nov 2009 at 8:10

[GoogleCodeExporter]

on the drums...the last CYMBLE note ont he drum fills for activation counts as 
a note
but BECAUSE it activates overdrive it just counts it as a "drum fill" hit...NOT 
a
note hit. if you miss/hit the activation cymble...on a drum fill yea it still 
counts
as a miss >> damn it i just FC'ED run to the hills but because there was drum
fills...its not an fc

Original comment by link8...@live.com on 8 May 2010 at 8:38

[GoogleCodeExporter]

Issue set to invalid due to one or more of the following reasons:
1) Age. This issue is considered abandoned.
2) Unrelated. The issue isn't related to FoFiX.
3) Fluke. The issue cannot be reproduced or was fixed long ago. (AKA: It's just 
you.)

Feel free to reply if you are certain the issue still exists and is relevant to 
FoFiX.

Original comment by fuzio...@gmail.com on 2 Sep 2010 at 1:39

• Changed state: Invalid