search

GamerBah / EnchantmentUpgrade

0 stars 1 forks source link

Cleanup of the 'old' package #2

Open GamerBah opened 5 years ago

GamerBah commented 5 years ago

The package old is simply code from the previous version of EU. This code should eventually be refactored into the new classes or removed for lack of necessity.

Events.java The InventoryClickEvent can be completely removed, as we'll be using InventoryToolkit from now on. Creation and handling of the inventory in the onClick(PlayerInteractEvent) should get refactored to use InventoryToolkit as well, since we can do much cleaner handling in there rather than a bunch of loops and if-elses.

Files.java Might be able to stay, but more on that can be discussed in issue #1

Methods.java OH BOY this class is a mess. Much of this can be refactored into the new Altar class, and some of it can be made into util classes. Using RelativeDirection is a pain and we should be using for-loops instead.

jaredtbates commented 5 years ago

First I need the project to be able to compile ;)

GamerBah commented 5 years ago

I'm debating wiping the whole project and just starting with new files cause we really shouldn't be trying to refactor code that's this old