Missing OpenCritic/Game Length

tejapoth commented 1 year ago

Hi Faiz, I will use this to occasionally update games that I find which are missing Opencritic or Game length!

Right now | missing Opencritic:

Travis Strikes Again: No More Heroes - https://opencritic.com/game/7117/travis-strikes-again-no-more-heroes

Should I play this - https://shouldiplaythis.com/?page=1&search=Travis%20Strikes%20Again:%20No%20More%20Heroes

There are 2 versions of Travis Strikes Again: No More Heroes one is complete edition and other is original and they both have opencritic. Regular version - https://opencritic.com/game/7117/travis-strikes-again-no-more-heroes Complete Edition - https://opencritic.com/game/8500/travis-strikes-again-no-more-heroes-complete-edition

SIPT only shows Opencritic for Complete edition and not for regular version. Cheers!

GamerKingFaiz commented 1 year ago

Thanks, fixed!

tejapoth commented 1 year ago

Hello again, Dead Space (Remake) opencritic is not coming up on SIPL unfortunately. https://shouldiplaythis.com/?page=1&search=Dead%20Space OC link: https://opencritic.com/game/13897/dead-space-remake-

Cheers!

GamerKingFaiz commented 1 year ago

Ah unfortunately for this one HLTB kept the name the same as the original, so if I fix it to match the original will also pick up the remaster's OC score. I'll have to see if I can put in some year matching logic in the future to help with cases like this.

tejapoth commented 1 year ago

ooh okay. so i guess in ur code there’s no way to do a one off manual assignment of opencritic to one particular game on HLTB? or is everything automated in your code? But all good, that would be great actually to implement a year system cos I noticed some games had high opencritic before i realised it was for the original version and not the remake!

tejapoth commented 1 year ago

Hi again, Lego DC Super Villains is missing OC https://shouldiplaythis.com/?page=1&search=Lego%20DC%20Super-Villains https://opencritic.com/game/6742/lego-dc-super-villains Cheers!

GamerKingFaiz commented 1 year ago

Fixed, thanks!

tejapoth commented 1 year ago

Hi again, AI: The Somnium Files - nirvanA Initiative is missing OC https://shouldiplaythis.com/?page=1&search=AI:%20THE%20SOMNIUM%20FILES%20-%20nirvanA%20Initiative https://opencritic.com/game/13265/ai-the-somnium-files-nirvana-initiative Cheers!

GamerKingFaiz commented 1 year ago

Fixed 👍🏼

tejapoth commented 1 year ago

Hello some more bugs for you. I decided to wait for a few games before I suggest bugs. So i have a few games to report so here i am! Missing OC: Persona 4 Golden : https://shouldiplaythis.com/?page=1&search=Persona%204%20Golden https://opencritic.com/game/9636/persona-4-golden Xenoblade Chronicles : https://shouldiplaythis.com/?page=1&search=Xenoblade%20Chronicles https://opencritic.com/game/9261/xenoblade-chronicles-definitive-edition Life is Strange : https://shouldiplaythis.com/?page=1&search=Life%20Is%20Strange https://opencritic.com/game/1995/life-is-strange-season-one

Single player Games listed as Co-Op on SIPT but HLTB only has “Main Story, + Extras , Complete” there can’t see time Mario + Rabbids Kingdom Battle - Donkey Kong Adventure https://shouldiplaythis.com/?page=1&search=Mario%20+%20Rabbids%20Kingdom%20Battle%20-%20Donkey%20Kong%20Adventure Bloodborne: The Old Hunters https://shouldiplaythis.com/?page=1&search=Bloodborne%20old

Cheers!

GamerKingFaiz commented 1 year ago

Thanks for all the reports!

I've fixed all the missing OC data.

And for the last two, HLTB has them classified as DLC. So I included DLC in the logic to display as a normal game (vs a multiplayer game). Those two and all other DLCs should be fixed!

tejapoth commented 1 year ago

Fantastic stuff buddy thanks!

tejapoth commented 1 year ago

Hello buddy more bugs for you.

Issues with ‘ in Luigi’s Mansion where nothing pops up until you type “Luigis Mansion” without apostrophes. Other examples: Zelda Link’s Awakening https://shouldiplaythis.com/?page=1&search=luigi%E2%80%99s%20mansion https://shouldiplaythis.com/?page=1&search=zelda%20link%E2%80%99s%20awakening

Cheers!

GamerKingFaiz commented 1 year ago

Missing OC:

Thanks for the reports! These are all fixed.

Issues with ‘ in Luigi’s Mansion where nothing pops up until you type “Luigis Mansion” without apostrophes.

Took me a little bit to figure out what was going on here, but I found that you're actually using a right single quote instead of a straight apostrophe. They look very similar, but you might be able to see the difference if you zoom in:

Right Single Quotation Mark:    ’
Straight Apostrophe:            '

I can't even type a right single quote on my keyboard, so I'm not sure how you're typing it. Perhaps you have a different keyboard layout. I would suggest you find the straight apostrophe on your keyboard and use that instead. If you use the right single quote directly on HLTB's site, you'll see it doesn't work there either (no results are returned).

tejapoth commented 1 year ago

Thanks for the reports! These are all fixed.

Awesome except one! Duke Nukem 3D is not fixed yet - https://shouldiplaythis.com/?page=1&search=Duke%20Nukem%203D:%2020th%20Anniversary%20World%20Tour - https://opencritic.com/game/3259/duke-nukem-3d-world-tour-20th-anniversary-edition

Right Single Quotation Mark: ’ Straight Apostrophe: '

Yeah that’s exactly what i suspected too. However it’s not because i’m using anything special. Im using US Keyboard layout on M1 Macbook which is like most of the macbook users.

But if you see the keyboard layout on Macbook we only have ‘ we don’t have straight apostrophe here. I attached below the exact keyboard layout used on Macbooks from official apple website. This is exactly what I have.

As you can see it’s not straight apostrophe like in Windows it’s slightly slanted ‘ I would appreciate if you added a filter to ignore ‘ as its literally what pops out when i type in macbooks, can’t change it!

GamerKingFaiz commented 1 year ago

Awesome except one! Duke Nukem 3D is not fixed yet

Oh good catch! It's fixed now.

I would appreciate if you added a filter to ignore ‘ as its literally what pops out when i type in macbooks, can’t change it!

I'd like to keep the search functionality on parity with what HLTB has and as I mentioned in the previous comment, the right single quote doesn't work on HLTB either.

Doing a quick search, it seems like there might be a setting called smart quotes you can disable on Mac.
https://discussions.apple.com/thread/252715831?answerId=255111236022#255111236022 If that doesn't work, there might be another setting that you could Google.

I don't use a Mac, so sorry I can't help much further. 😅 Workaround to this would be to just not type the apostrophe in the search.

tejapoth commented 1 year ago

Yeah I went down the rabbit hole after you posted about the smart quotes setting in macbooks and unfortuantely it’s an operating system thing, Apple forces it to be slanted like this ’ in words instead of straight '.

As you can see below i changed it to display as Windows style Straight apostrophe.

but that only works in quotes 'like so'. When I type the ' within a word like Luigi’s mansion it goes back to being slanted. HLTB

and SIPT

That's apple for you lol.

Would be great if some idea pops in your head to get rid of this. I can easily not type the apostrophe but the thing is I use a chrome extension called right click context search - where i right click a word and search that word within a website like SIPT. That’s why this causes issues! As I usually browse "best switch games" and then right click that game’s name and search it on SIPT like below which causes issues with games which have apostrophes or weird symbols 😂

GamerKingFaiz / shouldiplay

Missing OpenCritic/Game Length #10