Games-Gamers / FamBot

FAM
3 stars 0 forks source link

Resolved duplicate modification for vxtwitter links #73

Closed WikiWikiWasp closed 12 months ago

WikiWikiWasp commented 12 months ago

Bug

When posting vxtwitter links (seemingly without video embeds), fambot would repost the "fixed" link with multiple modifications. Ex: image

Fix

This seemed to be due to 3 things

  1. I was not aware of a modification for x.com links, so I had set their modification to vxtwitter to just replace the base url
  2. In the for loop that checked for needed modifications, if x.com is found as the base url, it would replace it with twitter.com
  3. Some links that say vxtwitter or twitter are actually x.com links, so it would replace the modification within the already modified link

image

Removing the reassignment of the x.com base url in the for loop as well as finding out there is a link mod for x.com (fixv - fixvx.com) fixes the issue

image