search

Games-and-Simulations / sc-docker

Multi-platform Version of StarCraft: Brood War in a Docker Container, ready to use for bot play simulations.
MIT License
231 stars 40 forks source link

Change way Java emedded in the Docker container #39

Closed kant2002 closed 6 years ago

kant2002 commented 6 years ago

When I trying to troubleshoot images, I have to build them. In the instructions there note that you should place jre_8_32bit_noinstall.zip in the docker folder. I initially go to the Oracle website in order to find latest Java executable, but did not find anything like that for Linux. There only jre-8u161-linux-i586.tar.gz for 32-bit version of JRE which I found. So I have to unpack TAR GZ archive and repackage it as ZIP in order to build. Which is not very obvious, and on Windows it will give not 100% same results as if image would be created in Linux (not interested for main usage, but possible solve some local issues).

From documentation standpoint would be probably better explicitly state that code from Oracle should be repackaged as ZIP archive, or replace code to use TAR GZ. and definitely provide information where to get archive required for packaging.

I no understand that I should take Windows version from Oracle website, but keep my initial thoughts, to indicate that I have initial confusion. For reference mostly.

This is potentially could interfere with #35 , specifically brownzach125@431f644dffbe7f9c7f1d5e2da0415f2d93f1be72, but it is better show the code with explanation of idea behind change, then try to replicate code with words. So if you think this is not worth the change, it could be scrapped. Or if it could be improved, that could serve as starting point.

michalsustr commented 6 years ago

Yep, it's a good idea. Merged.