search

Games-and-Simulations / sc-docker

Multi-platform Version of StarCraft: Brood War in a Docker Container, ready to use for bot play simulations.
MIT License
231 stars 40 forks source link

[PROPOSAL] Move integration tests to separated folder #61

Closed kant2002 closed 6 years ago

kant2002 commented 6 years ago

This is just proposal for discussion.

I would like to implement #52, #51 and #45 all of them greatly benefit from even simple unit testing which allow us prevent regressions. I think it is make sense separate integration tests which cover bigger part of workflow, from unit tests which will test only parts of behavior.

I do that PR on Windows, so I scary that I could change some permissions. Was not able to test since bats is not available on Windows too.

/cc: @michalsustr

michalsustr commented 6 years ago

Ok, why not. Did you make some unit tests?

kant2002 commented 6 years ago

Now I could start implementing them. I usually try to do unit tests together with some functionality, to simplify understanding and be consistent. Now I promise to add functionality with unittests, unless it require large refactoring. But I will try my best