search

Games-of-Switzerland / swissgamesgarden

👾 🇨🇭 Games of Switzerland - React Frontend Application
https://swissgames.garden
GNU General Public License v2.0
14 stars 1 forks source link

Problem with Taxinomy "Genres" + "State" #126

Closed DavidJavet closed 1 year ago

DavidJavet commented 1 year ago

I created the "Horror" and "Online Multiplayer" new genres. They appear with a "genres." in front. Also, there's a strange "M^Multiplayer" genre that doesn't seem linked to any games.

Whatsmore, a similar problem seems to appear in "State". With "Canceled" games appearing as "State.canceled"

Capture d’écran 2023-01-25 à 14 34 47 Capture d’écran 2023-01-25 à 14 34 24 Capture d’écran 2023-01-25 à 14 34 39 Capture d’écran 2023-01-25 à 14 34 32
WengerK commented 1 year ago

That's because all those labels are translatable and therfore they must be defined into our translations strings

https://github.com/Games-of-Switzerland/swissgamesgarden/blob/dev/src/locales/en.json

WengerK commented 1 year ago

I openned a PR with fixed translations "m^multiplayer" and new missing translations.

https://github.com/Games-of-Switzerland/swissgamesgarden/pull/129

May you review it @DavidJavet ?

DavidJavet commented 1 year ago

@WengerK THANKS! Should be good (sorry if I'm missing something)!