Games-of-Switzerland / swissgamesgarden

👾 🇨🇭 Games of Switzerland - React Frontend Application
https://swissgames.garden
GNU General Public License v2.0
14 stars 1 forks source link

Improve Game Teaser with multiple Genres & Platforms with +X mention #150

Closed WengerK closed 6 months ago

WengerK commented 6 months ago

💬 Demand There a problem with the Online Multiplayer genre tag: https://swissgames.garden/?genres[]=online_multiplayer

Screenshot 2024-02-26 at 08 26 23

🔢 Tasks

🎟 Reported on https://github.com/Games-of-Switzerland/swissgamesgarden/issues/149 by @DavidJavet

WengerK commented 6 months ago

fixed on staging @DavidJavet (URL to review: https://staging.swissgames.garden).

Thanks for confirming it works as you expected.

Screenshot 2024-02-26 at 09 27 43
DavidJavet commented 6 months ago

fixed on staging @DavidJavet (URL to review: https://staging.swissgames.garden).

Thanks for confirming it works as you expected.

Screenshot 2024-02-26 at 09 27 43

I am afraid this is not a good solution as the game image is unseable if we registered too many Platforms and Genres. The Game image should always take priority to the tags in my opinion.

WengerK commented 6 months ago

Thanks for your message, therefore it's out of my skills and needs design to fit your needs. Something with a [+1] or [+x] should be done

Do you want to propose something or do you prefer requesting helps from Pierre Georges ?

May we temporarly merge the proposed hotfix and then open a new Issue to improve multi Genres/Platforms with some design work ?

DavidJavet commented 6 months ago

I guess the best solution would be that after 1 entry (or 2 entries) of either "Genres" or "Platforms" we should see a [...]. Do you think that's feasible (without too much effort), or should we put that in the "nice-to-have" or "to have when budget" list?

WengerK commented 6 months ago

I can try something like that (not sure I will be able to do it [my frontend skills are limited] stil I can try)

Screenshot 2024-02-26 at 10 42 53
DavidJavet commented 6 months ago

You're amazing! Thanks a lot for trying!

WengerK commented 6 months ago

Here is the best I can achieve

Listing with +x elements

Screenshot 2024-02-28 at 19 14 15

Popover

Screenshot 2024-02-28 at 19 14 17
WengerK commented 6 months ago

testable on staging @DavidJavet

DavidJavet commented 6 months ago

Here is the best I can achieve

Listing with +x elements Screenshot 2024-02-28 at 19 14 15

Popover Screenshot 2024-02-28 at 19 14 17