Closed Corvimae closed 1 year ago
On initial examination things look good, though I'm confused why you're using both the rAF callback from usePIXICanvas, and useRafLoop if everything is happening with PIXI anyway? I don't think it matters much for execution, and might be better for splitting things up, but am curious if there's a specific reason.
the reason is i've never used Pixi before and was basing it largely off of the Desert Bus channel which has two loops lmfao
I'm concerned that the score text isn't quite obvious enough that it's the donation total, and that it should have at least a dollar sign and comma separators for legibility like other screens (thinking of making this explicit in contributing docs). I also think that it should be notably bigger, since the total should be one of the most prominent and immediately grabbing things about a screen. I do understand that you might be limited by the spritesheet, but I feel like these should be solvable.
Yeah that's currently just a spritesheet limitation, should be easy to change though.
the reason is i've never used Pixi before and was basing it largely off of the Desert Bus channel which has two loops lmfao
Ahh, right. Yeah, in the case of Desert Bus there is PIXI handling the drawing of the background, but the foreground is HTML, so I handled them in separate rAFs. In theory they could have been the same loop, but since they also dependent on different things having valid refs, I chose to keep them separate.
Ahh yeah that makes sense in retrospect. Updated!
Increased the size of the donation total and added comma separators and dollar sign.
did you know "rawr" means "please donate" in dinosaur :3