GamesDoneQuick / gdq-break-channels

Break Screen Channels for GDQ broadcasts
Other
141 stars 45 forks source link

feat: Add Celeste donation channel #14

Closed TarnishedStella closed 1 year ago

TarnishedStella commented 1 year ago

Description

Adding a new channel based on the game Celeste. The channel features Madeline looking out to the background watching the stars twinkle and strawberries fly by. Strawberries are spawned on a new donation event and depending on the amount, a different type of strawberry is spawned. Currently anything greater than or equal to $100.00 will spawn a golden strawberry but this can be adjusted as needed. Alternatively, it could be left up to chance instead of basing it on the actual donation amount if this aligns better with the overall goal.

Something else in this PR is that I added support for crediting via twitter, although i wasn't sure if this was acceptable. I made this in a separate commit that I can remove if need be.

I am a C# backend developer by day so please feel free to let me know where my javascript code can be improved or if anything doesn't make complete sense. I mostly based this channel on the existing channels (mostly trex and desert bus). I did try to reuse some of the sprite definitions but i was getting warnings in the console about loading an animation multiple times so i avoided this by having definitions for each sprite-sheet individually.

Celeste-Channel-Preview.webm

Checklist:

chrishanel commented 1 year ago

Hey, thanks for the submission!

I think this is looking pretty good, but we're going to say no to accepting because of the game's recency and the fact that it's still being actively published/marketed.

I appreciate the work you've put into this and hope that doesn't discourage you from potentially submitting another idea in the future. Thanks again!

TarnishedStella commented 1 year ago

Thanks for taking a look @chrishanel!

A little disappointing, but totally understandable. I remember reading that section of the contributing document when I was more than halfway through writing the code, and I started to get a little worried. I was holding onto some hope that it may be accepted since GDQ has showcased runs of the game as well as had different prizes relating to the game. I also know that the developers are generally welcoming of fan art and other fan projects so I guess I had convinced myself it would be okay to finish working on it lol.

Either way, I appreciate this opportunity to contribute to the marathon/GDQ (other than donating, of course). It was fun to create and try my hand at some frontend work, even if it can't be accepted at this time. The changes will still be on my fork if, by any stroke of luck, something changes in the future and the developers give explicit consent to GDQ.