Closed SushiElemental closed 7 months ago
Thanks very much for the submission! A vaporwave inspired channel is certainly playing to our designer's interests, and I'm personally keen to have something like this make it in.
That said, I have some feedback, and at least a few barriers to us merging this is that I'd like to see addressed before I can sign off on this.
I want to thank you again for the submission, and I really hope for something that this can reach a place we feel comfortable accepting.
Thank you for your feedback! I updated my main branch with the suggested changes and updated how donations are displayed.
It's close to bed time over here, need to rebase then tomorrow I guess. Could also update the preview video then as well.
Looking forward to your feedback
I think I got that rebasing PRs wrong - should I create another PR or can I still make this work somehow?
Here is the updated preview:
Hi! Okay I fixed my screwup in the Git history.
Please take a look again.
Description
Adds a new break channel with a 【 V A P O R W A V E 】 scenery. The channel shows a vaporwave inspired scenery with a magenta sky and blinking stars, a scrolling cyan grid at the bottom and a sun in the center. Donations show up in the upper half of the screen with a hover animation. They will cause a "cloud" in the scenery background to fly up. Subscriptions will show up as hearts flying out from the center.
The channel number is 15
https://github.com/GamesDoneQuick/gdq-break-channels/assets/46686799/8cea01db-c53b-4d0d-8b92-744d6a83b147
No new libraries are required.
Checklist: