GamesDoneQuick / gdq-break-channels

Break Screen Channels for GDQ broadcasts
Other
141 stars 45 forks source link

feat: add Cave Story channel #8

Closed omgitsraven closed 1 year ago

omgitsraven commented 1 year ago

The indie classic! A few points:

Description

Adds a new channel based on the original version of Cave Story.

A scene is shown of two characters standing on a ledge watching the night sky. Clouds scroll by in parallax layers, and the characters animate slightly (breathing, blinking) making it interesting even with no donations occurring. When a donation occurs, another character from the game (one of several) will fly past in the background, with the donation amount floating above their head.

https://github.com/GamesDoneQuick/gdq-break-channels/assets/8540042/359e3872-5473-4ccc-8f6e-22fc23d34e8c

Checklist:

omgitsraven commented 1 year ago

Is failing CI a problem, if it seemed to work fine in the browser? I never had any problems doing npm run preview so I assumed I was fine; if this is something I need to fix, what are the instructions for testing the build process locally so I can find out if my fixes are working without having to push commits all the way to github?

VodBox commented 1 year ago

If you run npm run build locally, you'll be able to see the same errors there

omgitsraven commented 1 year ago

Thank you! Hopefully this commit should fix it. Maybe the bit about npm run build should go in the contribution guide?

omgitsraven commented 1 year ago

also, I'm not totally familiar with GitHub's reviewing workflow, so let me know if there's any steps I'm missing on my end, sorry about that.

omgitsraven commented 1 year ago

The vars have been replaced by lets.

Sorry about the characters staying stuck on screen; I'm not sure how I missed that! Ironically, the animation actually DID take the characters all the way offscreen, but the lack of an animation-fill-mode was causing them to snap back to the left edge as soon as the animation finished. That's fixed now.

Thank you for being understanding about some of the less-proper bits of the program; this is still my only experience with React, and there's definitely aspects of it I don't totally grasp still.

I've also applied the requested visual changes to the donation total: image