Gaming32 / bingo

A multiloader bingo mod
https://modrinth.com/mod/bingo-mod
MIT License
4 stars 2 forks source link

Progress listeners break after logging out and back in #22

Closed RasmusAntons closed 4 months ago

RasmusAntons commented 4 months ago

If a player leaves the server and rejoins during a game, their goal progress is no longer updated (except once immediately after rejoining).

I don't exactly know why that happens, but my guess is that Minecraft doesn't allow multiple listeners for the same player on the same criterion. I tried around a bit and removing the listeners when a player quits solves this issue.

Gaming32 commented 4 months ago

Can you PR this fix?

RasmusAntons commented 4 months ago

Yes, I wasn't sure if that's how you want to implement it.