search

Gamua / Sparrow-Framework

The Open Source Game Engine for iOS
http://www.sparrow-framework.org
Other
294 stars 83 forks source link

SPPoolObject readability / more enhancements #21

Closed racarone closed 10 years ago

PrimaryFeather commented 10 years ago

Again, thanks a lot for our efforts, Robert!

I merged the readability changes with the Master tree — thanks a lot, that's now very concise and much easier to follow!

I haven't yet merged the additional performance enhancements, though. It's a great feat, and my pure allocation benchmarks show ~15% more performance. The code is extremely impressive, kudos to you!

However, it's also quite an amount of additional code that's rather cryptic, at least to my untrained eye. ;-) (I'm mainly talking about SPAtomic here). I don't think that's worth it (remember, all code that's in there has to be maintained and supported in the future). Especially since the Sparrow benchmark itself did not show that difference.

Would you be very disappointed if I left that out? ;-)

racarone commented 10 years ago

I merged the readability changes with the Master tree — thanks a lot, that's now very concise and much easier to follow!

I haven't yet merged the additional performance enhancements, though. It's a great feat, and my pure allocation benchmarks show ~15% more performance. The code is extremely impressive, kudos to you!

Thanks!

However, it's also quite an amount of additional code that's rather cryptic, at least to my untrained eye. ;-) (I'm mainly talking about SPAtomic here). I don't think that's worth it (remember, all code that's in there has to be maintained and supported in the future). Especially since the Sparrow benchmark itself did not show that difference.

Would you be very disappointed if I left that out? ;-)

Nah it's fine, it was just copied from Apple's source anyways. I updated the branch and removed it.

PrimaryFeather commented 10 years ago

Thanks for your understanding, Robert! :-)