search

Gamua / Sparrow-Framework

The Open Source Game Engine for iOS
http://www.sparrow-framework.org
Other
294 stars 83 forks source link

Modified sparrow for Xcode 6.4 #45

Closed MrLarryLi closed 9 years ago

MrLarryLi commented 9 years ago

Hello again,

I think it's great that Sparrow got updated. It did mess up my changes so I removed most of them. I figured out that I should put these changes in a branch to make things easier. Now I just need to figure out how to squash the commits.

Here's the list of changes: 1) I did make the code work with Xcode 6.4 by wrapping almost all the generics. I put the link on how in SPSparrowBase.h. The only one that I couldn't wrap was SPCache. 2) I fixed enabling multitouch in SPViewController. In my setup, the view was nil when the boolean was assigned. 3) I thought NSCopying required implementing copyWithZone:. I changed the methods to reflect this. 4) There are some methods that seem to be only in iOS 9. (SPMatrix3D and SPViewController) 5) I did change colors to have 255 as the alpha component to be consistent and other minor changes. 6) There is an issue with libz. I don't know the proper way to link it and make it work with Xcode 6 and 7.

Let me know if you want me to change something.

racarone commented 9 years ago

1.) I'm willing to pull in the generics support for Xcode 6.4, can you create a new pull request with only the generics support? 2.) I think this is already fixed, but let me know if otherwise. 3.) NSCopying does require 'copyWithZone' to be implemented, but since zones are completely unused, 'copy' is currently just forwarding to 'copyWithZone' on classes implementing NSCopying. There shouldn't be any problem with this, but if there is please let us know. 4.) You can include this in the new pull request. 6.) Yeah I don't think there is a way to fix this without creating separate projects for 6.x and 7.x. The SDKs use completely different file types for libraries.

Thanks for the pull request though! Some of the previous additions are either already fixed or features best left for extensions. Though, I see you reverted many of those changes.

We've also decided against including a '.framework' target currently as it's a dynamic framework which requires iOS 8+ to use. It's easier to just include the project for now.

I'm going to close this pull request just in order to keep the commit history clean. If you don't mind creating a new pull request for the generics support based from the current master that'd be great! Thanks Larry!

PrimaryFeather commented 9 years ago

Thanks from me as well, to both of you! =)