search

Gamua / Starling-Framework

The Cross Platform Game Engine
http://www.starling-framework.org
Other
2.82k stars 821 forks source link

How to compare 2.4.2 to 2.4.1 #1052

Closed chrisvelevitch closed 5 years ago

chrisvelevitch commented 5 years ago

Up until recently, I've been using 2.4.1 and then I updated to 2.4.2 which resulted in my project no longer compiling. I switched back to 2.4.1 and the problem goes away. I wanted to see what the differences are between the two only to be disappointed in that there no branches for either version.

Where do I find the code bases for 2.4.1 and 2.4.2?

JohnBlackburne commented 5 years ago

Here’s a comparison of 2.4.1 to the current master:

https://github.com/Gamua/Starling-Framework/compare/a1ae146...master

Select 'files changed' to view individual changes in files. There are a lot of them though. If you are seeing compile errors post them, as that will narrow things down greatly.

PrimaryFeather commented 5 years ago

Yeah, please let me know the exact compiler errors you're getting! Thanks in advance!

chrisvelevitch commented 5 years ago

@JohnBlackburne So you are saying master is 2.4.2 as there hasn't been any new commits since 2.4.2 was released? And where does it say commit a1ae146 is 2.4.1? Isn't it best practice to tag the commit that was used to create a release with the release number? I don't see and tags for 2.4.1 and 2.4.2.

@PrimaryFeather The compile error is:-

Error:(2004, 37) Class<starling.display.Mesh> has no field createDefaultStyle (Suggestions: set_defaultStyle, get_defaultStyle)

but looking closely at that class, I don't understand why I'm getting the error.

JohnBlackburne commented 5 years ago

createDefaultStyle is a static function. You need to call it like this

Mesh.createDefaultStyle(mesh)

not

mesh.createDefaultStyle()

which will generate an error like that

I compared it to the head revision as I cannot see which revision is 2.4.2. Revision 2.4.1 is labelled as such on that commit.

PrimaryFeather commented 5 years ago

Actually, the latest stable AS3 version of Starling is "2.4", and there's a tag for that. "2.4.1" is the current development version.

Could it be that you're talking about the Haxe version of Starling? This is the AS3 repository. :wink:

chrisvelevitch commented 5 years ago

Sorry, my mistake. Do mean the haxe version of Starling.

PrimaryFeather commented 5 years ago

No problem! :smile: