Open HaimZik opened 5 years ago
Thanks a lot for the pull request! I‘m currently on a vacation, so I haven‘t been able to look into it in detail yet. Domain memory usage has always been tricky, especially when attempting to integrate it directly into the framework and not have any negative side effects in some situations or on some platforms, so this needs to be carefully evaluated. I‘ll do that when I‘m back home!
Unlike previous efforts this implementation does not use one big ByteArray but switch between ByteArray only for each ByteArray which is bigger than ApplicationDomain.MIN_DOMAIN_MEMORY_LENGTH(1024 bytes). There is no memory fragmentation because the largest allocation is the size of the max batch length. Context3d createVertexBuffer limit batch size to 65535 vertices and 256 byte per vertex, which is 16.77696 megabyte.
There is no (significant) impact on memory. Apps which use high poly count will benefit, such as apps that use particle system. I made a branch of the Particle System which make use of this update. https://github.com/HaimZik/Starling-Extension-Particle-System
An performance analysis.
https://forum.starling-framework.org/d/21731-made-starling-use-domain-memory