search

Gamua / Starling-Framework

The Cross Platform Game Engine
http://www.starling-framework.org
Other
2.82k stars 821 forks source link

Juggler: Fixed pooled tweens & delayed calls not properly released in pool when purging the juggler (V2) #1103

Closed Adolio closed 1 year ago

Adolio commented 1 year ago

Hey Daniel,

Here is a second implementation following your comment on https://github.com/Gamua/Starling-Framework/pull/1101.

It seems to be working fine on my side but I didn't run the unit tests suite. Could you double check?

See you! Aurélien

*Sorry for the white spaces cleaning 😬

PrimaryFeather commented 1 year ago

Yeah, that's just perfect! The new event makes it much cleaner – and I'm talking not only about the pull request, but the Juggler code in general. Thanks a lot for the great work!

I ran the unit tests – and the juggler is heavily testes – and they completed just fine. So everything should be fine!

Don't worry about the whitespace, haha! That happens to me all the time. 🤪

Adolio commented 1 year ago

Thanks a lot Daniel for the review and the merge!

I'm very happy that you like the proposed changes 😁

See you soon