search

Gamua / Starling-Framework

The Cross Platform Game Engine
http://www.starling-framework.org
Other
2.87k stars 826 forks source link

[~] Added a returnPlay property to MovieClip. #816

Open B-Interactive opened 8 years ago

B-Interactive commented 8 years ago

This is a feature I've put into a current project. When enabled, the clip will play to the end, then effectively play in reverse back to the start, in a back-forth way. I thought I'd see if it could be worked into the MovieClip class as a built in property.

In effect, it replicates the existing frames and adds them in reverse to the MovieClipFrames vector.

In handling things like numFrames and currentFrame, I've obscured the return value to only reflect the original clip. The reasoning is I thought it'd be easier for people to continue treating the clip as unchanged in length and framecount, it simply plays in reverse when it gets to the end.

I'm uncertain if currentTime should be obscured in the same way, my gut feeling is it should remain unobscured, so the full play time back and forth, is twice the normal play time.

When adding and removing frames to a clip, if returnPlay is active, the logic works like this: if (returnPlay == true) returnPlay = false: remove the mirrored frames add or remove frames returnPlay = true: re-mirror the frames

There's perhaps a more elegant way to do this rather than destroying and re-creating all the mirrored frames each time, but it's not something I anticipate needs to be done too frequently so I've left it for now.

Known quirks: The first and last frames of the clip are doubled. I'm not sure if this is an issue, or expected behaviour?

PrimaryFeather commented 8 years ago

Thanks a lot for the pull request! I'm currently working at bug fixes and performance improvements of Starling 2, but as soon as that's done, I'll have a detailed look at your proposal. Thanks for your efforts! :smile:

B-Interactive commented 8 years ago

No worries Daniel, all that you're doing in Starling 2 is hugely appreciated 😀

David

On 22 March 2016 at 23:07, Daniel Sperl notifications@github.com wrote:

Thanks a lot for the pull request! I'm currently working at bug fixes and performance improvements of Starling 2, but as soon as that's done, I'll have a detailed look at your proposal. Thanks for your efforts! [image: :smile:]

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Gamua/Starling-Framework/pull/816#issuecomment-199782332