search

Gamua / Starling-Framework

The Cross Platform Game Engine
http://www.starling-framework.org
Other
2.84k stars 819 forks source link

Fix ColorMatrix tint method #921

Open mathieuanthoine opened 7 years ago

mathieuanthoine commented 7 years ago

To get the exact Adobe Animate tint, you need to remove the LUMA factor from the tint method.

PrimaryFeather commented 7 years ago

Thanks a lot for the pull request, and sorry for the late reply (I was on a vacation).

May I ask where you've got this information from? I must admit the existing code was just copied from here, and I haven't checked if the output is identical to what Adobe Animate produces.

The problem with this change is that it will change the color output of all all existing users of this method, which might be problematic.

What do others say? I'd prefer to have the same output as Adobe Animate, but I'm not too happy changing people's tinting. 😐

mathieuanthoine commented 7 years ago

May I ask where you've got this information from? I must admit the existing code was just copied from here, and I haven't checked if the output is identical to what Adobe Animate produces.

I've checked it myself, comparing graphic results, your and my code.

The problem with this change is that it will change the color output of all all existing users of this method, which might be problematic.

You're right except if developers that use it expect the same result as in Animate.

The safer solution is certainly to change the documentation for tint removing the description and create an editorTint method with the description you have at the moment for tint :)

PrimaryFeather commented 7 years ago

Thanks for the update!

To everybody else in the loop: what's your opinion on this? Any heavy users of this method around?

binouze commented 7 years ago

I used tint in m'y previous game an i remember having problems to get the same result as in flash pro. I think the solution to create an another method is good, so no need to find every usage of the tint method to retune it on the next update :)

mathieuanthoine commented 7 years ago

I found strange behaviors in Starling. Using the same shader in PixiJs and Starling, the result is different. I think that the shader is the right one but in some case the result is unexpected.. Please don't merge this PR before I found why the results in Starling are not as we could expected. Thanks.

PrimaryFeather commented 7 years ago

Thanks for the feedback, @binouze!

@mathieuanthoine: What you're describing might be a difference in how PixiJS handles premultiplied alpha. In Starling 2, all colors are expected to use premultiplied alpha, and I'm making up for that in the shader. I don't know what PixiJS does in this respect. (Could be something else entirely, of course — I just thought I mention it.)

mathieuanthoine commented 7 years ago

I'm not as solid as I would like about Shaders in Starling/AS3, how can I help to fix the tint method ?

PrimaryFeather commented 7 years ago

@mathieuanthoine Do you mean that in PixiJS, the results are identical with those from Adobe Animate, but Starling produces different results (even with your changes)?

mathieuanthoine commented 7 years ago

@PrimaryFeather Not exactly I'll try to be clearer.

If in PixiJS I use the shader I give you for Starling, you will have the same tint as Animate. In Starling it works in some cases (that's why at the beginning I thought that it works for Starling and PixiJS) and doesn't work in other cases.

I think the best way to check if the shader is the good one would be to apply the shader on a classic MovieClip in Animate.