Gamua / Starling-Framework

The Cross Platform Game Engine
http://www.starling-framework.org
Other
2.82k stars 821 forks source link

Employing the `numSides` parameter for elliptical gen methods #960

Closed EhsanMarufi closed 7 years ago

EhsanMarufi commented 7 years ago

The useful parameter of numSides in the constructor of the internal class of Ellipse is implemented and available; why not allow the users to benefit the advantages of the parameter?! As the class provides a resolution-independent concept, one may need to have more control on the sides' count, e.g. where the shape may be scaled in a way the imperfection of the to-be elliptical curve is undesirable, and the issue could've been solved easily, if there were more sides on the shape!

PrimaryFeather commented 7 years ago

You're perfectly right, it makes sense to make that parameter generally available. To be honest, I don't know why I didn't do it in the first place ...

Thanks a lot for taking the time to set up the pull request!!