search

GandaG / pyfomod

A high-level fomod library written in Python.
https://pyfomod.rtfd.io/
Apache License 2.0
7 stars 6 forks source link

Fix Installer crashes #6

Closed Lahvuun closed 5 years ago

Lahvuun commented 5 years ago

Options in info.options are already of Option type, not InstallerOption, hence the option._object call fails with e.g.:

  File "/home/lahvuun/git/cemm/cemm_venv/lib/python3.6/site-packages/pyfomod/installer.py", line 284, in flags
    for info in self._previous_pages
  File "/home/lahvuun/git/cemm/cemm_venv/lib/python3.6/site-packages/pyfomod/installer.py", line 285, in <listcomp>
    for option in info.options
AttributeError: 'Option' object has no attribute '_object'

Probably a leftover from a local revision.

GandaG commented 5 years ago

Good job! All that's missing is fixing the tests (files and flags)

Lahvuun commented 5 years ago

I'm sorry for the delay.

GandaG commented 5 years ago

Squashed and merged, thanks!