Implement dns parsing - Githubissues

Gandem / bonjour-reflector

A reflector that forwards mdns packets between VLANs - like avahi-reflector but with fine-grained control !

MIT License

177 stars 37 forks source link

Closed Gandem closed 6 years ago

Gandem commented 6 years ago

Unpack udp payload and parse DNS contents, and formats it for logging purposes
Avoid parsing packets twice : in the previous approach packets where already parsed and we parsed them again using NewDecodingLayerParser. As this method reused variables, it introduced bugs where simple dns requests would be interpreted as Bonjour packets.

NB: The Dot1Q extraction is commented for the moment as it is not used yet.

cc @KSerrania @oxlay for review :eyes:

KSerrania commented 6 years ago

Lgtm :+1:

KSerrania commented 6 years ago

Since #7 contains this PR, I think we can close this one.