search

GangCaoLab / CoolBox

Jupyter notebook based genomic data visualization toolkit.
https://gangcaolab.github.io/CoolBox/index.html
GNU General Public License v3.0
224 stars 37 forks source link

Equal aspect for hic matrix #91

Open Phlya opened 8 months ago

Phlya commented 8 months ago

I think equal aspect looks much better for the Hi-C matrix, makes pixels actually square... Perhaps it can be an argument passed to the track, but IMO equal aspect is a better default. What do you think?

Nanguage commented 8 months ago

Hello, I also noticed this issue before. I also believe that setting pixels to be square is a better default value. Unfortunately, I didn't do any Hi-C related work later on, which resulted in a lack of time to maintain this project at the moment. If there are no issues after making the modifications and testing them on your end, please notify me to proceed with the merge. Thank you for your contribution!

Phlya commented 8 months ago

I think it works fine for me, the only issue (which is simply the limitations of laws of mathematics) is that with a small height of the track the heatmap might not fill the whole width of the frame...

Nanguage commented 8 months ago

Can you provide some graphical examples?