Gankra / cargo-mommy

Mommy's here to support you when running cargo~
https://faultlore.com/cargo-mommy/
Apache License 2.0
726 stars 49 forks source link

mommy confused her pronouns a bit~ #49

Closed isaacg1 closed 9 months ago

isaacg1 commented 9 months ago

This line in the thirsty, positive responses doesn't work if one changes the default pronoun:

                "give {pronoun} a kiss~",

With the default pronoun of "her", it reads "give her a kiss", which works. But if one changes the pronoun to "their", it reads "give their a kiss". If one changes the pronoun to "his", it reads "give his a kiss". "their" and "his" are the two alternative pronouns mentioned in the README, so they should be supported.

The problem arises from the fact that "her" is used elsewhere as a dependent genitive pronoun, corresponding to "his" and "their", but is used here as an accusative pronoun, corresponding to "him" and "them".

To fix this, I think it would be easiest to say that "her" should always be used in parallel with "their" and "his", in the dependent genitive case, and to change this response to

                "give {role} a kiss~",

e.g. "give mommy a kiss~".