Ganom / Supporter-Issue-Tracker

This is an ISSUE-ONLY repo. This is used for reporting issues/feature requests for supporter plugins.
https://www.ganomsoftware.com/
0 stars 5 forks source link

RCBot "Master/Slave" - Slave Banking + Master trade screen issues #164

Open TearGaming opened 3 years ago

TearGaming commented 3 years ago

Describe the bug A clear and concise description of what the bug is. there are two "bugs" 1) the slave: when it is banking and withdraws too many rings of duelling, more than one, it will get stuck in the bank and is unable to fix itself.

2)the master: when the slave trades with the master, sometimes the slave puts the things (ess and or binding nec) up 1 tick after the master has accepted the trade. cancelling the master's trade. then the master is stuck in the trade screen. if you manually accept both trade screens, the master and slave both will be stuck. (to solve that you have to accept first trade screen and then close second trade screen, and it will continue as normal)Or if for some reason the slave doesn't press accept it will also get stuck in the trade screen.

To Reproduce Steps to reproduce the behavior: to reproduce, have a lag spike, or high ping lol

For slave: getting stuck at bank only happens when it runs out of duel rings and needs to withdraw more.

Expected behavior A clear and concise description of what you expected to happen. i would expect the master and the slave to have a fail safe, a recheck after so many given ticks, that it would check what state it is on and if it has not continued from that state, it would do it again.

for the slave: if it gets stuck in the bank, have it deposit the entire inv and re withdraw the things needed. for the master/slave: on the trade screen, if it gets stuck, have it re-attempt to trade.

Screenshots If applicable, add screenshots to help explain your problem. I will attach what it looks like for the bank, but it being stuck in the trade screen is self-explanatory

Additional context Add any other context about the problem here. When the slave is stuck in the bank, and it withdraws like as shown in the image, it will continue to withdraw more ess. It for some reason does not consider any items above the secound dueling ring. And thus does not know the inventory is full.

Screen Shot 2021-01-24 at 1 06 13 PM