GantMan / jail-monkey

A React Native library for identifying if a phone is rooted or mocking locations
MIT License
566 stars 143 forks source link

False alarm on Samsung S8 and A7 #73

Open unicornRainbows opened 3 years ago

unicornRainbows commented 3 years ago

I get a false alarm that the device has been rooted when it has not been rooted..

I feel like this might be a Samsung related issue since the is another issue related to this that has not been solved. https://github.com/GantMan/jail-monkey/issues/58

Any help would be appreciated, I will give you an electronic 🍫 .. (Which you can copy paste to make as many as you would like.. hehe)

❤️

unicornRainbows commented 3 years ago

It works as expected on a Samsung Galaxy A50..

unicornRainbows commented 3 years ago

I think I found the solution to my problem..

I was using JailMonkey.trustFall() which checks for a rooted device as well as if location is being mocked.. Testing now just with JailMonkey.isJailBroken()

Will let you know. BTW Android devices without being rooted allow other apps to simulate the location of the device which can cause the JailMonkey checks to fail.. Why android why???

morelgarisi commented 3 years ago

any updates on this?

unicornRainbows commented 3 years ago

This was due to Android having an app that allowed for location spoofing. The issue was on my side.. also maybe a note, make sure testers are not spooofing location and that you use the correct checks. We now only check for root detection.

Sent from my iPhone

On 18 Nov 2020, at 15:08, Morel notifications@github.com wrote:

 any updates on this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

morelgarisi commented 3 years ago

i only check root with JailMonkey.isJailBroken() , and there are still devices that i get true although they are not rooted (checked them with root checker - android) is there still an issue with not rooted android but simulate the location of the device? is this the cause for get JailMonkey.isJailBroken() true?

levibuzolic commented 3 years ago

@morelgarisi shouldn't be, no - it's only trustFall which checks both isJailBroken and canMockLocation.

There does seem to be some false positives with isJailBroken though. Any information you can provide on specific devices/cases would be helpful.

quantumarun commented 3 years ago

Got Reported it on "Samsung Galaxy Note 20 Ultra 5G". Any clue or suggestion how to get around it. I might be happy to look around and contribute if you can guide around. As for device even i don't have that. Using isJailBroken only.

jordanjoecooper commented 2 years ago

@quantumarun If you run the sample app here: https://play.google.com/store/apps/details?id=com.scottyab.rootbeer.sample&hl=en_GB&gl=US

What does it flag as the reason for root on the Samsung Galaxy Note 20 Ultra 5g?

RohitPatilAtShell commented 1 year ago

@morelgarisi shouldn't be, no - it's only trustFall which checks both isJailBroken and canMockLocation.

There does seem to be some false positives with isJailBroken though. Any information you can provide on specific devices/cases would be helpful.

I am also getting this issue in one of my client device: Brand: Samsung OS: Lineageos-18 Android: 11

I have already tested that the device is not rooted(attached screenshot). Its a false alarm!!!

Please help me to get this issue resoled. Thanks in advance.

MicrosoftTeams-image (6)