Add ability to override options based on device version + goodies

GantMan / react-native-siren

The React Native port of the popular Siren / Harpy Pod and hopefully Gradle

156 stars 26 forks source link

Closed reimertz closed 5 years ago

reimertz commented 5 years ago

[x] adds the ability to pass in version overrides based on what version a user have.
[x] surface the performCheck() function
[x] ignore node_modules

reimertz commented 5 years ago

The more I think about it, the more I think this might be something people should implement themselves rather than us adding complexity?

by surfacing performCheck, we give the user the ability to check what remote versions are available, creating their own strategy.

What you think @GantMan?

GantMan commented 5 years ago

Hah, I can't believe this project had node_modules included! WTH!? Such a stupid mistake years ago :)

I like the changes! Let's merge em