search

GantMan / react-native-siren

The React Native port of the popular Siren / Harpy Pod and hopefully Gradle
156 stars 26 forks source link

App link #6

Closed winseyli closed 5 years ago

winseyli commented 5 years ago

Think the app link http://itunes.apple.com/app/id[Apple_ID] is gone and the new one should be https://apps.apple.com/app/id[Apple_ID] ? And the uri starting with "itmss" should no longer be a valid case too. Thank you photo_2019-10-08_16-46-15

GantMan commented 5 years ago

ah! Would you want to make a PR since you found this?

If not, I'll fix.

winseyli commented 5 years ago

Kindly have a check

GantMan commented 5 years ago

perfect!

winseyli commented 5 years ago

@GantMan how can we have this as new release on npm? Thanks!

GantMan commented 5 years ago

Yup! BTW, @winseyli - are you interested in getting access to release? This project could use a second maintainer.

winseyli commented 5 years ago

Yes that sounds interesting! Thank you!

GantMan commented 5 years ago

@winseyli - I added you as a contributor on GitHub - what's your NPM username?

winseyli commented 5 years ago

just registered... same as the one on github :)

GantMan commented 5 years ago

awesome! You've been added. Let me know if you need any help. You should have all the access you need to bump the version number and publish 👍