GantMan / react-native-siren

The React Native port of the popular Siren / Harpy Pod and hopefully Gradle
156 stars 26 forks source link

Bundle ID is wrong #9

Closed Rubenvdveen closed 3 years ago

Rubenvdveen commented 3 years ago

I ran into an error while using sp-react-native-in-app-updates, which uses this package for iOS. The return status was "Could not fetch the latest version".

After debugging I found out that the Bundle ID that react-native-device-info got, was wrong. Something with brackets and some key/values.

I know this is more of a problem in react-native-device-info, but maybe this package should allow you to pass your own Bundle ID as an optional parameter? That would fix the issue for me.

GantMan commented 3 years ago

Sounds good. PR welcome

Rubenvdveen commented 3 years ago

@GantMan done :). Thanks for the quick response.