Gapminder / ddf-validation

How do you know your DDF dataset is ✅valid?
https://open-numbers.github.io/ddftools.html
GNU General Public License v3.0
7 stars 2 forks source link

Fix bug in datapackage entity set primary key definition #534

Closed jheeffer closed 5 years ago

jheeffer commented 5 years ago

Old logic was wrong.

file: ddf--entities--geo--country.csv headers: country, name, gender country is entity set, gender is entity domain would give primary key gender

Updated logic handles this correctly.

Moreover, imagine you want to set a property geo on a country entity

with updated logic in ddf--entities--geo.csv you can't because geo MUST be key in ddf--entities--geo--country.csv you can because country will be key if used next to geo

defining country property on geo is still possible in ddf--entities--geo file or any other entity set file. defining geo on geo is still impossible (was never possible) due to csv ambiguity.