Gapminder / dollar-street-pages

Dollar Street public pages
https://www.gapminder.org/dollar-street/
GNU General Public License v3.0
14 stars 23 forks source link

feat(DS): #1134 save selected currency on navigate to map and country pages #1174

Closed Miffael closed 6 years ago

Miffael commented 6 years ago

feat(DS): #1134 save selected currency on navigate to map and country pages, refactor update - add few interfaces

codecov-io commented 6 years ago

Codecov Report

Merging #1174 into development will increase coverage by 0.9%. The diff coverage is 39.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #1174     +/-   ##
==============================================
+ Coverage        44.88%   45.78%   +0.9%     
==============================================
  Files              138      140      +2     
  Lines             6040     6135     +95     
  Branches           898      910     +12     
==============================================
+ Hits              2711     2809     +98     
+ Misses            3090     3074     -16     
- Partials           239      252     +13
Impacted Files Coverage Δ
...x/matrix-view-block/matrix-view-block.component.ts 55% <ø> (+2.09%) :arrow_up:
.../common/street-settings/street-settings.service.ts 53.33% <ø> (ø) :arrow_up:
...rc/shared/street-pinned/street-pinned.component.ts 25.37% <0%> (ø) :arrow_up:
...rc/shared/street-mobile/street-mobile.component.ts 27.65% <0%> (ø) :arrow_up:
src/common/language/language.service.ts 22.22% <0%> (ø) :arrow_up:
...hared/things-filter/ngrx/things-filter.reducers.ts 71.42% <100%> (ø) :arrow_up:
...rc/shared/street-family/street-family.component.ts 72.5% <100%> (ø) :arrow_up:
...countries-filter/ngrx/countries-filter.reducers.ts 77.77% <100%> (ø) :arrow_up:
src/test/index.ts 100% <100%> (ø) :arrow_up:
src/shared/street/street.component.ts 43.15% <100%> (ø) :arrow_up:
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4096952...8dcf4e7. Read the comment docs.