Gapminder / dollar-street-pages

Dollar Street public pages
https://www.gapminder.org/dollar-street/
GNU General Public License v3.0
14 stars 23 forks source link

Embed: User can add new photo after share link is generated. #1324

Open AntonOlkhovskyi opened 6 years ago

AntonOlkhovskyi commented 6 years ago

Context

After clicking on "Share now" button, the user gets a generated preview modal with share link and images he has added. On this stage user now able to add more images to sharing preview, by clicking on family images. But link he will share afterward will not contain families added after preview modal generation.

Steps to reproduce

  1. Click Heart icon on floating menu and add two families to share.
  2. Click Share now button.
  3. Click on family image in content area, one which is not yet selected.

Expected result

New family image is added to the sharing modal dialog.

Current result

Family image is not clickable and can't be added to the sharing modal dialog.

Possible Fix

Need to disable the ability to add family images after sharing modal dialog was generated.

Browsers

Chrome 66 FF 59