search

Gapminder / dollar-street-pages

Dollar Street public pages
https://www.gapminder.org/dollar-street/
GNU General Public License v3.0
14 stars 23 forks source link

Move button to activate embed feature from floating footer to menu #1328

Open Miffael opened 6 years ago

Miffael commented 6 years ago

Move button to activate embed feature from floating footer to the menu. Remove the button that triggers the embed feature from the floating footer and adds it to the main menu. In the menu, it should be called 'Create a Comparison'.

AntonOlkhovskyi commented 6 years ago

Hi @Miffael , I have three remarks according to the task:

  1. When you click on CREATE COMPARISON it is became highlighted with green color. Can we remove it?
  2. Is it was renamed from Create a Comparison to CREATE COMPARISON? Please confirm if so.
  3. It looks really weird to have this menu item after social networks icons. As for me, this menu item should be added after Map and before social networks icons. And also we need to add translation key, for this item, to have it on the crowdin, at the moment we develop it.